Skip to content

Commit b43c2d5

Browse files
committed
fix: Merge conflct
1 parent 5c0c76b commit b43c2d5

File tree

2 files changed

+27
-23
lines changed

2 files changed

+27
-23
lines changed

src/ai/backend/manager/event_dispatcher/handlers/artifact_registry.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,7 @@ async def handle_artifact_registry_pull(
184184
models=models,
185185
registry_name=reservoir_registry_data.name,
186186
storage_name=reservoir_config.storage_name,
187+
storage_step_mappings=reservoir_config.storage_step_selection,
187188
)
188189

189190
# Call storage proxy import API

src/ai/backend/storage/services/artifacts/reservoir.py

Lines changed: 26 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -131,32 +131,35 @@ async def import_model(
131131
reporter: ProgressReporter for tracking progress
132132
storage_step_mappings: Mapping of import steps to storage names
133133
"""
134-
if model.revision is None:
135-
raise ArtifactRevisionEmptyError(f"Revision must be specified for model: {model}")
136-
137-
# Create import context
138-
context = ImportStepContext(
139-
model=model,
140-
registry_name=registry_name,
141-
storage_pool=self._storage_pool,
142-
progress_reporter=reporter,
143-
storage_step_mappings=storage_step_mappings,
144-
step_metadata={},
145-
)
146-
147-
# Execute import pipeline
148-
await pipeline.execute(context)
149-
150-
log.info(f"Model import completed: {model}")
134+
success = False
135+
try:
136+
if model.revision is None:
137+
raise ArtifactRevisionEmptyError(f"Revision must be specified for model: {model}")
151138

152-
await self._event_producer.anycast_event(
153-
ModelImportDoneEvent(
154-
model_id=model.model_id,
155-
revision=model.resolve_revision(ArtifactRegistryType.RESERVOIR),
139+
# Create import context
140+
context = ImportStepContext(
141+
model=model,
156142
registry_name=registry_name,
157-
registry_type=ArtifactRegistryType.RESERVOIR,
143+
storage_pool=self._storage_pool,
144+
progress_reporter=reporter,
145+
storage_step_mappings=storage_step_mappings,
146+
step_metadata={},
147+
)
148+
149+
# Execute import pipeline
150+
await pipeline.execute(context)
151+
log.info(f"Model import completed: {model}")
152+
success = True
153+
finally:
154+
await self._event_producer.anycast_event(
155+
ModelImportDoneEvent(
156+
success=success,
157+
model_id=model.model_id,
158+
revision=model.resolve_revision(ArtifactRegistryType.RESERVOIR),
159+
registry_name=registry_name,
160+
registry_type=ArtifactRegistryType.RESERVOIR,
161+
)
158162
)
159-
)
160163

161164
async def import_models_batch(
162165
self,

0 commit comments

Comments
 (0)