Skip to content

Conversation

@seedspirit
Copy link
Contributor

resolves #6966 (BA-3162)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

Copilot AI review requested due to automatic review settings November 27, 2025 09:24
@github-actions github-actions bot added size:XS ~10 LoC comp:manager Related to Manager component labels Nov 27, 2025
@seedspirit seedspirit added this to the 25.15 milestone Nov 27, 2025
Copilot finished reviewing on behalf of seedspirit November 27, 2025 09:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes HandleHeartbeatAction.spec() from the list of supported actions in the agent processors, effectively excluding agent heartbeat handling from being listed as a supported action. This aligns with the treatment of other internal system actions.

  • Removes HandleHeartbeatAction from the supported_actions() method return list
  • Maintains the actual heartbeat processing functionality (processor still initialized and functional)
  • Follows the existing pattern where internal actions like mark_agent_exit and mark_agent_running are also excluded from supported_actions()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link
Collaborator

@HyeockJinKim HyeockJinKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we be looking at the part where we're applying action monitors, rather than removing the spec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:manager Related to Manager component size:XS ~10 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove agent heartbeat handling observation from audit log

3 participants