Skip to content

Commit 519b2d9

Browse files
committed
Refactor Dockerfile to use more secure image version and method of mounting authorized_keys
1 parent 6b2573c commit 519b2d9

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

Language/node.js/18/Dockerfile

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,17 @@ RUN apt-get update && \
99
apt-get install -y curl && \
1010
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash && \
1111
export NVM_DIR="$([ -z "${XDG_CONFIG_HOME-}" ] && printf %s "${HOME}/.nvm" || printf %s "${XDG_CONFIG_HOME}/nvm")" && \
12-
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" && \
12+
[ -s "$NVM_DIR/nvm.sh" ] && \
13+
. "$NVM_DIR/nvm.sh" && \
1314
nvm install 18 && \
15+
nvm use 18 && \
1416
npm install -g typescript yarn pnpm && \
1517
apt-get clean && \
1618
rm -rf /var/lib/apt/lists/* && \
1719
chown -R devbox:devbox /home/devbox/project && \
1820
chmod -R u+rw /home/devbox/project && \
1921
chmod -R +x /home/devbox/project/entrypoint.sh
20-
22+
23+
ENV NVM_DIR="/root/.nvm"
24+
2125
RUN mkdir /root/.devbox

Language/node.js/update_cn_dockerfile.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ sed -i '$i\
99
COPY /OS/debian-ssh/debian.sources /etc/apt/sources.list.d/debian.sources' "$TMP_DOCKERFILE"
1010

1111
sed -i '$i\
12-
RUN npm config set -g registry https://registry.npmmirror.com' "$TMP_DOCKERFILE"
12+
RUN bash -c "source $NVM_DIR/nvm.sh && npm config set -g registry https://registry.npmmirror.com"' "$TMP_DOCKERFILE"

0 commit comments

Comments
 (0)