Minor issue with "Other"

[01micko]

I would say this is fairly low priority but nonetheless worth a mention.

1. No icon for other. Perhaps fallback to the labwc icon? Since we only run in labwc it should always be there and I can't see any point in configuring and searching for a fallback.
2. Not localised. I don't think it's worth adding gettext for such a corner case. Maybe an option? eg: -L Andra :)

If you think it's worth the effort I'll take it on, or if you have another suggestion I'm listening.

[johanmalm]

I don't understand this one. AFAIU we already have i18n and icon for 'Other' in schema.h

The icon is applications-other which I think appears in all icon themes I have installed. Checking /usr/share/desktop-directories that icon is the one that lxqt, lxde and xfce use for 'other'.

Could you explain the context in which it is not working as you expect it to?

Ref:

• labwc-menu-generator/schema.h

  Line 540 in f1aa43d

  { "Name[sv]", "Övrigt" },

• labwc-menu-generator/schema.h

  Line 551 in f1aa43d

  { "Icon", "applications-other" },

[01micko]

Sorry I see it's localised but no icon?

		printf("  <menu id=\"%s\" label=\"%s\">\n",
			dir->name, dir->name_localized ? : dir->name);
		printf("%s", submenu->str);
		printf("  </menu> <!-- %s -->\n", dir->name);

It's likely a bug. I see no ''Other" icon in my menu but applications-other.svg exists in my icon theme.

[01micko]

#30 should fix it fine

[johanmalm]

Thanks. Get it now.

Looks like I do not have any apps in Other which is why I had not notices it.

[01micko]

Ready for an 0.1.1 tag now?