From 079f199ae8510530d48424a6ce4a598d95cae71c Mon Sep 17 00:00:00 2001
From: Dima Tsonkova <dima03214@yahoo.com>
Date: Tue, 20 Nov 2018 16:01:59 +0200
Subject: [PATCH] Shuffling is unnecessary and comparator initialization should
 happen earlier.

---
 src/main/java/com/lagodiuk/ga/GeneticAlgorithm.java | 3 +--
 src/main/java/com/lagodiuk/ga/Population.java       | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/main/java/com/lagodiuk/ga/GeneticAlgorithm.java b/src/main/java/com/lagodiuk/ga/GeneticAlgorithm.java
index 9069f31..9f969c8 100644
--- a/src/main/java/com/lagodiuk/ga/GeneticAlgorithm.java
+++ b/src/main/java/com/lagodiuk/ga/GeneticAlgorithm.java
@@ -51,7 +51,7 @@ public void clearCache() {
 		}
 	}
 
-	private final ChromosomesComparator chromosomesComparator;
+	private final ChromosomesComparator chromosomesComparator = new ChromosomesComparator();
 
 	private final Fitness<C, T> fitnessFunc;
 
@@ -71,7 +71,6 @@ public void clearCache() {
 	public GeneticAlgorithm(Population<C> population, Fitness<C, T> fitnessFunc) {
 		this.population = population;
 		this.fitnessFunc = fitnessFunc;
-		this.chromosomesComparator = new ChromosomesComparator();
 		this.population.sortPopulationByFitness(this.chromosomesComparator);
 	}
 
diff --git a/src/main/java/com/lagodiuk/ga/Population.java b/src/main/java/com/lagodiuk/ga/Population.java
index be4c943..0858ad6 100644
--- a/src/main/java/com/lagodiuk/ga/Population.java
+++ b/src/main/java/com/lagodiuk/ga/Population.java
@@ -51,7 +51,6 @@ public C getChromosomeByIndex(int indx) {
 	}
 
 	public void sortPopulationByFitness(Comparator<C> chromosomesComparator) {
-		Collections.shuffle(this.chromosomes);
 		Collections.sort(this.chromosomes, chromosomesComparator);
 	}