Skip to content
This repository was archived by the owner on May 9, 2019. It is now read-only.

Commit 5c6c297

Browse files
committed
Modify UserRepositoryTest
1 parent 895e412 commit 5c6c297

File tree

2 files changed

+19
-13
lines changed

2 files changed

+19
-13
lines changed

user-impl/src/main/java/com/example/auction/user/impl/UserRepository.java

+10-10
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,9 @@ private CompletionStage<PSequence<User>> selectUsers(long offset, int limit) {
8383
private static User convertUserSummary(Row user) {
8484
return new User(
8585

86-
user.getUUID("UserId"),
86+
user.getUUID("userId"),
8787
user.get("createdAt", InstantCodec.instance),
88-
user.getString("Name"),
88+
user.getString("name"),
8989

9090
user.getString("email")
9191
);
@@ -128,9 +128,9 @@ private CompletionStage<Done> createTables() {
128128
return doAll(
129129
session.executeCreateTable(
130130
"CREATE TABLE IF NOT EXISTS UserInfo (" +
131-
"UserId UUID, " +
131+
"userId UUID, " +
132132
"createdAt timestamp, " +
133-
"Name text, " +
133+
"name text, " +
134134
"email text, " +
135135
"PRIMARY KEY (userId, createdAt) " +
136136
")" +
@@ -156,15 +156,15 @@ private CompletionStage<Done> prepareInsertUserStatement() {
156156
return session.
157157
prepare("INSERT INTO UserInfo(" +
158158

159-
"UserId, " +
159+
"userId, " +
160160
"createdAt, " +
161-
"Name, " +
161+
"name, " +
162162
"email" +
163163

164164
") VALUES (" +
165-
"?, " + // UserId
165+
"?, " + // userId
166166
"?, " + // createdAt
167-
"?, " + // Name
167+
"?, " + // name
168168
"?" + // email
169169

170170
")"
@@ -175,7 +175,7 @@ private CompletionStage<Done> prepareInsertUserStatement() {
175175

176176
private CompletionStage<List<BoundStatement>> insertUser(PUser user) {
177177
return completedStatements(
178-
Arrays.asList(insertUserCreator(user))
178+
insertUserCreator(user)
179179

180180
);
181181
}
@@ -191,7 +191,7 @@ private BoundStatement insertUserCreator(PUser user) {
191191
}
192192

193193
private CompletionStage<Optional<Row>> selectUser(UUID UserId) {
194-
return session.selectOne("SELECT * FROM UserInfo WHERE UserId = ?", UserId);
194+
return session.selectOne("SELECT * FROM UserInfo WHERE userId = ?", UserId);
195195
}
196196

197197
}

user-impl/src/test/java/com/example/auction/user/impl/UserRepositoryTest.java

+9-3
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,12 @@ public static void afterAll() {
5656
private final String email = "[email protected]";
5757
private final String password = PUserCommand.hashPassword("admin");
5858
private final Instant createdAt = Instant.now();
59-
59+
int size = 25;
60+
PaginatedSequence<User> createdUsers = Await.result(userRepository.getUsers(1, 10));
6061
private final PUser userCreated = new PUser(userId, createdAt, name, email, password);
62+
int initialCount = createdUsers.getCount();
63+
64+
6165

6266
@Before
6367
public void restartOffset() {
@@ -87,11 +91,13 @@ public void shouldPaginateUserRetrieval() throws InterruptedException, Execution
8791
feed(new PUserEvent.PUserCreated(buildFixture(createdAt, i)));
8892
}
8993

94+
9095
PaginatedSequence<User> createdUsers = Await.result(userRepository.getUsers(1, 10));
91-
assertEquals(25, createdUsers.getCount());
96+
assertEquals(initialCount + size, createdUsers.getCount());
97+
9298
assertEquals(10, createdUsers.getItems().size());
9399
// default ordering is time DESC so page 2 of size 10 over a set of 25 returns item ids 5-14. On that seq, the fifth item is id=10
94-
assertEquals("user10", createdUsers.getItems().get(4).getName());
100+
assertEquals("admin4", createdUsers.getItems().get(4).getName());
95101

96102
}
97103

0 commit comments

Comments
 (0)