feat(levm): implement EIP7691 - Blob throughput increase #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Benchmark Results ComparisonPR ResultsBenchmark Results: Factorial
Benchmark Results: Fibonacci
Main ResultsBenchmark Results: Factorial
Benchmark Results: Fibonacci
|
lima-limon-inc
commented
Jan 23, 2025
There was a problem hiding this comment.
All thanks to @fborello-lambda ;)
lima-limon-inc
changed the title
lima-limon-inc
commented
Jan 23, 2025
| @@ -43,13 +45,13 @@ pub mod create_opcode { | |||
| } | |||
|
|
|||
| pub const VERSIONED_HASH_VERSION_KZG: u8 = 0x01; | |||
| pub const MAX_BLOB_NUMBER_PER_BLOCK: usize = 6; | |||
There was a problem hiding this comment.
This constant is not used in LEVM. However, there is an identical constant present here: https://github.com/lambdaclass/ethrex/blob/main/crates/blockchain/constants.rs#L51
There was a problem hiding this comment.
Explained here: #1782 (comment)
…_NUMBER_PER_BLOCK
lima-limon-inc
commented
Jan 23, 2025
lima-limon-inc
added
ef-tests
lima-limon-inc
commented
Jan 23, 2025
crates/blockchain/constants.rs
Outdated
Comment on lines
48
to
51
| pub const TARGET_BLOB_NUMBER_PER_BLOCK: u64 = 3; | ||
|
|
||
| /// Max number of blobs per block | ||
| pub const MAX_BLOB_NUMBER_PER_BLOCK: u64 = 2 * TARGET_BLOB_NUMBER_PER_BLOCK; | ||
| pub const MAX_BLOB_NUMBER_PER_BLOCK: u64 = 6; |
There was a problem hiding this comment.
Explained here: #1782 (comment)
lima-limon-inc
commented
Jan 23, 2025
…GET_BLOB_NUMBER_PER_BLOCK" This reverts commit f04ba07.
…o fix/levm/blob_txs
ilitteri
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
LEVM needs to support the changes introduced in EIP-7691.
Description
This EIP introduces changes to some of the blob hashes' constants values. With this PR, the values for blob hash calculations in LEVM will depend on the spec being used.
Closes #1783
Closes #1776