You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- [Rustfmt](https://github.com/rust-lang/rustfmt), [Clippy](https://github.com/rust-lang/rust-clippy), [Rustdoc](https://doc.rust-lang.org/rustdoc/index.html) and [Typos](https://github.com/crate-ci/typos) linting is included in CI pipeline. Anyways it's preferable to run linting locally before push. To simplify running these commands in a reproducible manner we use `make` commands, you can run:
74
+
- [Rustfmt](https://github.com/rust-lang/rustfmt), [Clippy](https://github.com/rust-lang/rust-clippy), [Rustdoc](https://doc.rust-lang.org/rustdoc/index.html), [Typos](https://github.com/crate-ci/typos) and [Taplo](https://github.com/tamasfe/taplo) linting is included in the CI pipeline.
75
75
76
-
```
77
-
make lint
78
-
```
76
+
You can run all checks locally before opening a PR. To simplify running all checks in a reproducible manner we use `make` commands:
79
77
80
-
You can find more information about other `make` commands in the [Makefile](Makefile)
78
+
```
79
+
make lint
80
+
```
81
+
82
+
You can find more information about other `make` commands in the [Makefile](Makefile).
81
83
82
84
### Versioning
83
85
We use [semver](https://semver.org/) naming convention.
84
86
85
87
## Pre-PR checklist
86
-
1. Repo forked and branch created from `next` according to the naming convention.
87
-
2. Commit messages and code style follow conventions.
88
-
3. Tests added for new functionality.
89
-
4. Documentation/comments updated for all changes according to our documentation convention.
90
-
5. Rustfmt, Clippy and Rustdoc linting passed.
88
+
89
+
> [!TIP]
90
+
> You can check if you have the tools that we use by running `make check-tools`.
91
+
92
+
- Repo forked and branch created from `next` according to the naming convention.
93
+
- Commit messages and code style follow conventions.
94
+
- Tests added for new functionality, with all previously existing tests passing.
95
+
- Read more on how to run integration tests [here](./tests/README.md).
96
+
- Documentation/comments updated for all changes according to our documentation convention.
97
+
- Lints: Rustfmt, Clippy, Rustdoc, Typos and TOML-formatting linting passing.
98
+
- As mentioned above, `make lint` can be used for checking there.
99
+
- If the PR includes changes to the web client, the documentation needs to be up to date. You can automatically generate them by running `make typedoc`.
100
+
101
+
### Changelog
102
+
103
+
If a PR introduces anything a downstream user might notice - a new feature, a behaviour change, a bug-fix, a deprecation, or a breaking API change - add a bullet to [CHANGELOG.md](./CHANGELOG.md) under the last existing heading (corresponds to the unreleased version when working on the `next` branch). The convention is to write a past-tense summary (e.g. "* [BREAKING] Renamed foo() to bar() in `Client` {#PR number link}"). Internal refactors or smaller tweaks that don’t affect public behaviour can be left out.
91
104
92
105
## Write bug reports with detail, background, and sample code
Copy file name to clipboardExpand all lines: tests/README.md
+9-2Lines changed: 9 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -18,13 +18,20 @@ And on a second terminal do:
18
18
make integration-test-full
19
19
```
20
20
21
+
For running web client integration tests, you can do:
22
+
23
+
```bash
24
+
# This will run the integration test suite for the web SDK
25
+
make integration-test-web-client
26
+
```
27
+
21
28
Note that in order to run this as part of a CI/CD workflow (at least on github), you'll need to use `make start-node-background` instead so the process keeps running on background.
22
29
23
30
To stop the background node, you can use the `make stop-node` command.
24
31
25
-
## Integration Test Flow
32
+
## Integration tests flow
26
33
27
-
The integration test goes through a series of supported flows such as minting and transferring assets which runs against a running node.
34
+
The integration testing suite goes through a series of supported flows such as minting and transferring assets which runs against a running node.
0 commit comments