feat(cli): add Docker support and usage instructions in README #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khuzama98
changed the title
|
|
||
| # Run rex commands | ||
| docker run --rm rex --help | ||
| docker run --rm rex balance 0x... --rpc-url https://ethereum.node.url |
There was a problem hiding this comment.
The command doesn't seem to have a --rpc-url flag, the rpc url is passed directly without it, same with the other commands
|
|
||
| # Run rex commands | ||
| docker run --rm rex --help | ||
| docker run --rm rex balance 0x... --rpc-url https://ethereum.node.url |
There was a problem hiding this comment.
I think it would be better to state the example commands as
docker run --rm rex balance <ADDRESS> <RPC_URL>
So that they are easier to follow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Docker support to Rex CLI with usage instructions in README file.
Resolves #136
Closes #136