some comments and experiments on TestMain

Author: lambdai

tests/integration/pilot/filterchain/filterchain_test.go

@@ -11,36 +11,50 @@ import (
 	"time"
 )
 
+
 func TestMain(m *testing.M) {
-	framework.Main("filterchain_test", m)
+
 	// TODO
 	// No need to enforce kube for filter chain
 	// set up envoy
 	// set up client and app
 	// set up pilot
+	print("In TestMain")
+	framework.Main("filterchain_test", m)
+
+	// NOTE: print(m) only run once no matter how many TestXX is given
+	print(m)
+	// no need to explicitly invoke os.Exit as it's part of framework.Main
+	// os.Exit(m.Run())
+}
+
+func TestBar(t *testing.T) {
+	t.Log("in TestBar")
 }
 
 func TestFoo(t *testing.T) {
+	t.Log("in TestFoo")
+	return
 	ctx := framework.NewContext(t)
 	defer ctx.Done(t)
 
-	ctx.RequireOrSkip(t, environment.Native)
+	ctx.RequireOrSkip(t, environment.Kube)
 
 	pilot := pilotcomponent.NewOrFail(t, ctx, pilotcomponent.Config{})
 
 	applications := apps.NewOrFail(ctx, t, apps.Config{Pilot: pilot})
 
-	aApp := applications.GetAppOrFail("a", t)
-	bApp := applications.GetAppOrFail("b", t)
+	aApp := applications.GetAppOrFail("a", t).(apps.KubeApp)
+	bApp := applications.GetAppOrFail("b", t).(apps.KubeApp)
 
 	for _, e := range bApp.Endpoints() {
 		t.Logf("b end point %s", e)
 	}
 
 	retry.UntilSuccessOrFail(t, func() error {
-		bPort := bApp.EndpointsForProtocol(apps.AppProtocolHTTP)[0]
+		bEndpoint := bApp.EndpointForPort(80)
 		bProtocol := apps.AppProtocolHTTP
-		results, err := aApp.Call(bPort,
+		results, err := aApp.Call(bEndpoint,
 			apps.AppCallOptions{
 				Protocol: apps.AppProtocol(bProtocol),
 			})
@@ -54,7 +68,7 @@ func TestFoo(t *testing.T) {
 				fmt.Printf("Result: %v\n", results[0])
 			}
 			return fmt.Errorf("%s to %s:%d using %s: expected success, actually failed",
-				aApp.Name(), bApp.Name(), bPort, bProtocol)
+				aApp.Name(), bApp.Name(), 80, bProtocol)
 		}
 		return nil
 	}, retry.Delay(time.Second), retry.Timeout(10*time.Second))