Skip to content

Commit ebf43df

Browse files
sdakeistio-testing
authored andcommitted
properly report errors on failure (istio#12945)
The CI Infrastructure times out after 10 minutes of no activity. In one of the test case runners, 10 miniutes is specified causing the CI timeout to flush any debuggable output from the checks. This results in an in-exact error result to be returned. Instead a vague reponse about the test case timing out is reported, resulting in confusion for the PR authors. The typical max I was able to achieve was ~230 seconds, but I trimmed to 3 minutes so the test case fails in all conditions and properly reports the errors.
1 parent abb9b2c commit ebf43df

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Diff for: tests/e2e/framework/kubernetes.go

+4-2
Original file line numberDiff line numberDiff line change
@@ -543,8 +543,10 @@ func (k *KubeInfo) Teardown() error {
543543
}
544544
}
545545

546-
// confirm the namespace is deleted as it will cause future creation to fail
547-
maxAttempts := 600
546+
// NB: Increasing maxAttempts much past 230 seconds causes the CI infrastructure
547+
// to terminate the test run not reporting what actually failed in the deletion.
548+
maxAttempts := 180
549+
548550
namespaceDeleted := false
549551
validatingWebhookConfigurationExists := false
550552
log.Infof("Deleting namespace %v", k.Namespace)

0 commit comments

Comments
 (0)