refactor horizontal scrolling in DrawsTabs::tabs() method

ProjektGopher · ProjektGopher · commit 2a8dc6d40cc2 · 2024-04-30T19:36:49.000-07:00
diff --git a/src/Themes/Default/Concerns/DrawsTabs.php b/src/Themes/Default/Concerns/DrawsTabs.php
@@ -39,11 +39,11 @@ protected function tabs(
 
         // automatic horizontal tab scrolling
         if ($strippedWidth($top_row) > $width) {
+            $scroll = $selected / ($tabs->count() - 1);
             $chars_to_kill = $strippedWidth($top_row) - $width;
-            $percent = $selected / ($tabs->count() - 1);
-            $left = (int) round($percent * $chars_to_kill);
+            $offset = (int) round($scroll * $chars_to_kill);
             foreach ([&$top_row, &$middle_row, &$bottom_row] as &$row) {
-                $row = mb_substr($row, $left, mb_strwidth($row) - $chars_to_kill);
+                $row = mb_substr($row, $offset, mb_strwidth($row) - $chars_to_kill);
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -39,11 +39,11 @@ protected function tabs(`
`39`	`39`
`40`	`40`	`// automatic horizontal tab scrolling`
`41`	`41`	`if ($strippedWidth($top_row) > $width) {`
	`42`	`+ $scroll = $selected / ($tabs->count() - 1);`
`42`	`43`	`$chars_to_kill = $strippedWidth($top_row) - $width;`
`43`		`- $percent = $selected / ($tabs->count() - 1);`
`44`		`- $left = (int) round($percent * $chars_to_kill);`
	`44`	`+ $offset = (int) round($scroll * $chars_to_kill);`
`45`	`45`	`foreach ([&$top_row, &$middle_row, &$bottom_row] as &$row) {`
`46`		`- $row = mb_substr($row, $left, mb_strwidth($row) - $chars_to_kill);`
	`46`	`+ $row = mb_substr($row, $offset, mb_strwidth($row) - $chars_to_kill);`
`47`	`47`	`}`
`48`	`48`	`}`
`49`	`49`