Avoid valgrind warnings about uninitialized memory from SoftHSM

Author: Jakuje

.github/setup-valgrind.sh

@@ -8,10 +8,9 @@ if [ "$1" == "valgrind" -o "$2" == "valgrind" ]; then
 	./configure --disable-notify
 	make clean && make -j 4 V=1
 
-	# suppression file contains supressions for the notification support which leaks memory
-	# The other option would  be to build without the notification support.
-	# export VALGRIND="valgrind --error-exitcode=1 --leak-check=full --keep-debuginfo=yes --suppressions=$PWD/tests/opensc.supp"
-	export VALGRIND="valgrind -q --error-exitcode=1 --leak-check=full --keep-debuginfo=yes --trace-children=yes --gen-suppressions=all"
+	# suppression file contains supressions for softhsm providing us with uninitialized mechanism flags
+	# https://github.com/opendnssec/SoftHSMv2/commit/f94aaffc879ade97a51b8e1308af42f86be1885f
+	export VALGRIND="valgrind -q --error-exitcode=1 --leak-check=full --keep-debuginfo=yes --trace-children=yes --gen-suppressions=all --suppressions=$PWD/tests/opensc.supp"
 	# this should help us getting better traces as some of pcsclite and avoid false positives
 	export LD_PRELOAD="/usr/lib/x86_64-linux-gnu/libpcsclite.so.1"
 fi

tests/Makefile.am

@@ -12,8 +12,8 @@ AM_TESTS_ENVIRONMENT = \
 
 @VALGRIND_CHECK_RULES@
 if VALGRIND_ENABLED
-#VALGRIND_SUPPRESSIONS_FILES = opensc.supp
-#EXTRA_DIST = opensc.supp
+VALGRIND_SUPPRESSIONS_FILES = $(srcdir)/opensc.supp
+EXTRA_DIST += opensc.supp
 VALGRIND_FLAGS = --num-callers=30 -q --keep-debuginfo=yes --gen-suppressions=all
 # Do not run the bash scripts under valgrind
 LOG_COMPILER = $(LOG_VALGRIND)

tests/opensc.supp

@@ -0,0 +1,39 @@
+{
+   SoftHSM provides us with uninitialized flags
+   Memcheck:Cond
+   fun:supported_mechanisms_test
+   obj:/usr/lib/x86_64-linux-gnu/libcmocka.so.0.7.0
+   fun:_cmocka_run_group_tests
+   fun:main
+}
+{
+   SoftHSM provides us with uninitialized flags
+   Memcheck:Cond
+   fun:get_mechanism_all_flag_name
+   fun:supported_mechanisms_test
+   obj:/usr/lib/x86_64-linux-gnu/libcmocka.so.0.7.0
+   fun:_cmocka_run_group_tests
+   fun:main
+}
+{
+   SoftHSM provides us with uninitialized flags
+   Memcheck:Cond
+   fun:_itoa_word
+   fun:__vfprintf_internal
+   fun:printf
+   fun:supported_mechanisms_test
+   obj:/usr/lib/x86_64-linux-gnu/libcmocka.so.0.7.0
+   fun:_cmocka_run_group_tests
+   fun:main
+}
+{
+   SoftHSM provides us with uninitialized flags
+   Memcheck:Value8
+   fun:_itoa_word
+   fun:__vfprintf_internal
+   fun:printf
+   fun:supported_mechanisms_test
+   obj:/usr/lib/x86_64-linux-gnu/libcmocka.so.0.7.0
+   fun:_cmocka_run_group_tests
+   fun:main
+}