Deprecate in favour of driftyco/ionic-unit-testing-example

[lathonez]

Ionic are now maintaining a repo which is pretty much the same as this - it uses @angular/cli and supports unit testing. It will support e2e soon as I understand it.

https://github.com/driftyco/ionic-unit-testing-example

The purpose of this issue is to update our codebase to use their example, check everything is working, and shut everything down!

See also ionic-team/ionic-unit-testing-example#5

[masimplo]

Just wanted to thank you personally for your effort all this time. You made our lives that much easier. Your repo was the first thing I visited every time Ionic2/karma/ng-cli/node/circleci/istanbul/whatever released an update instead of spending hours to figure out what needs tinkering.

A big thanks from me and my team!

[lathonez]

@masimplo thanks for all your contributions and your kind words on the other issue. It's been great working with you.

[kamok]

I looked over their repo on the official driftyco one. I see some considerably different configuration, such as the lack of a Test Utils. What would be the recommended procedure to migrating to their setup?

[superkew]

Thanks for all your work. This repo has helped me extensively!

[kamok]

@superkew I wish I can get him something nice =). This repo has been vital for the past 5 months working with Ionic and Jasmine + Karma testing.

[lathonez]

I see some considerably different configuration, such as the lack of a Test Utils

Max changed the structure of the repo a lot last night, now it is very different, so it is not using @angular/cli anymore.

However - if this is the way Ionic recommend to proceed we should all follow suit and contribute over there.

Re the lack of a TestUtils - this is a subjective thing. I like TestUtils (I am testing a large project based on this code with over 450 tests, and I like consolidating the boilerplate). If you want to keep the TestUtils, I suggest keeping it yourself in a separate utilities class.

If you don't want to keep it, you can write the code in-line: https://github.com/lathonez/clicker/blob/master/src/pages/page2/page2.spec.ts#L15-L32

The idea of this is issue is that it will show how to migrate to Ionic's new setup. I have not been able to put a lot of time into it yet.

[lathonez]

ionic-team/ionic-unit-testing-example#7

[lathonez]

TODO:

• test-coverage: Add Test Coverage ionic-team/ionic-unit-testing-example#12
• test-ci: Single run ionic-team/ionic-unit-testing-example#14
• e2e: e2e testing using protractor ionic-team/ionic-unit-testing-example#10

[lathonez]

3a8b610 - two tests failing to do with button clicks events. Tried various different methods. Latest is the accepted answer here which (apart from being the correct way to do these click events), seems to work the second time around: http://stackoverflow.com/questions/40093013/testing-click-event-in-angular2-testing

Once tests are passing, need to investigate the above. Then test on larger project.

[lathonez]

Added PRs for outstanding missing functionality (as above). Just need to sort those two failing tests.

[lathonez]

Since I've moved to driftyco/ionic-unit-testing-example, I'm getting two failing tests:

• https://github.com/lathonez/clicker/blob/master/src/components/clickerForm/clickerForm.spec.ts#L28-L37
• https://github.com/lathonez/clicker/blob/master/src/components/clickerButton/clickerButton.spec.ts#L31-L39

I've tried re-writing these in a variety of ways (the latter is the latest recommended on SO) - nothing doing.

Tonight I've realised that if I run both those spec files in isolation, the tests run fine.. which is worrying?

[lathonez]

Removing app.component.spec.ts makes everything pass.