fix: values from aws secrets manager are secret

johnb8 · johnb8 · commit c0bd6b46d3f8 · 2025-05-22T10:00:11.000-06:00
diff --git a/app-config-aws-secrets-manager/package.json b/app-config-aws-secrets-manager/package.json
@@ -31,6 +31,7 @@
   },
   "dependencies": {
     "@app-config/extension-utils": "^2.9.0-beta.1",
+    "@app-config/extensions": "^2.9.0-beta.1",
     "@aws-sdk/client-secrets-manager": "3.810.0"
   },
   "peerDependencies": {
diff --git a/app-config-aws-secrets-manager/src/index.ts b/app-config-aws-secrets-manager/src/index.ts
@@ -1,6 +1,7 @@
 import type { ParsingExtension, Json } from '@app-config/main';
 import { named, forKey, validateOptions } from '@app-config/extension-utils';
 import { SecretsManager } from '@aws-sdk/client-secrets-manager';
+import { markAllValuesAsSecret } from '@app-config/extensions';
 
 function awsSecretsManagerParsingExtension(): ParsingExtension {
   return named(
@@ -32,7 +33,7 @@ function awsSecretsManagerParsingExtension(): ParsingExtension {
               }
             }
 
-            return parse(value, { shouldFlatten: true });
+            return parse(value, { shouldFlatten: true }, undefined, [markAllValuesAsSecret()]);
           },
       ),
     ),
diff --git a/new-version.sh b/new-version.sh
@@ -37,6 +37,7 @@ new_version() {
   cd $prev
 }
 
+new_version app-config-aws-secrets-manager
 new_version app-config-cli
 new_version app-config-config
 new_version app-config-core

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`import type { ParsingExtension, Json } from '@app-config/main';`
`2`	`2`	`import { named, forKey, validateOptions } from '@app-config/extension-utils';`
`3`	`3`	`import { SecretsManager } from '@aws-sdk/client-secrets-manager';`
	`4`	`+import { markAllValuesAsSecret } from '@app-config/extensions';`
`4`	`5`
`5`	`6`	`function awsSecretsManagerParsingExtension(): ParsingExtension {`
`6`	`7`	`return named(`
`@@ -32,7 +33,7 @@ function awsSecretsManagerParsingExtension(): ParsingExtension {`
`32`	`33`	`}`
`33`	`34`	`}`
`34`	`35`
`35`		`- return parse(value, { shouldFlatten: true });`
	`36`	`+ return parse(value, { shouldFlatten: true }, undefined, [markAllValuesAsSecret()]);`
`36`	`37`	`},`
`37`	`38`	`),`
`38`	`39`	`),`
Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,7 @@ new_version() {`
`37`	`37`	`cd $prev`
`38`	`38`	`}`
`39`	`39`
	`40`	`+new_version app-config-aws-secrets-manager`
`40`	`41`	`new_version app-config-cli`
`41`	`42`	`new_version app-config-config`
`42`	`43`	`new_version app-config-core`