Skip to content

Commit a98db42

Browse files
authored
fix: rename ModelConfig method to Config (#52)
The latest specification renames `ModelConfig` to `Config`.
1 parent 3541236 commit a98db42

File tree

6 files changed

+13
-13
lines changed

6 files changed

+13
-13
lines changed

pkgs/sdk/server-ai/docs-src/namespaces/LaunchDarkly.Sdk.Server.Ai.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,5 @@ var aiClient = new LdAiClient(new LdClientAdapter(baseClient));
1717

1818
// Pass in the key of the AI config, a context, and a default value in case the config can't be
1919
// retrieved from LaunchDarkly.
20-
var myModelConfig = aiClient.ModelConfig("my-model-config", Context.New("user-key"), LdAiConfig.Disabled);
20+
var myModelConfig = aiClient.Config("my-model-config", Context.New("user-key"), LdAiConfig.Disabled);
2121
```

pkgs/sdk/server-ai/src/Config/LdAiConfig.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ internal ModelConfiguration(string id, IReadOnlyDictionary<string, LdValue> para
7979

8080
/// <summary>
8181
/// Builder for constructing an LdAiConfig instance, which can be passed as the default
82-
/// value to the AI Client's <see cref="LdAiClient.ModelConfig"/> method.
82+
/// value to the AI Client's <see cref="LdAiClient.Config"/> method.
8383
/// </summary>
8484
public class Builder
8585
{

pkgs/sdk/server-ai/src/Interfaces/ILdAiClient.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,6 @@ public interface ILdAiClient
2424
/// <param name="defaultValue">the default config, if unable to retrieve from LaunchDarkly</param>
2525
/// <param name="variables">the list of variables used when interpolating the prompt</param>
2626
/// <returns>an AI config tracker</returns>
27-
public ILdAiConfigTracker ModelConfig(string key, Context context, LdAiConfig defaultValue,
27+
public ILdAiConfigTracker Config(string key, Context context, LdAiConfig defaultValue,
2828
IReadOnlyDictionary<string, object> variables = null);
2929
}

pkgs/sdk/server-ai/src/LdAiClient.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public LdAiClient(ILaunchDarklyClient client)
4444
private const string LdContextVariable = "ldctx";
4545

4646
/// <inheritdoc/>
47-
public ILdAiConfigTracker ModelConfig(string key, Context context, LdAiConfig defaultValue,
47+
public ILdAiConfigTracker Config(string key, Context context, LdAiConfig defaultValue,
4848
IReadOnlyDictionary<string, object> variables = null)
4949
{
5050

pkgs/sdk/server-ai/test/InterpolationTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ private string Eval(string prompt, Context context, IReadOnlyDictionary<string,
3939
mockClient.Setup(x => x.GetLogger()).Returns(mockLogger.Object);
4040

4141
var client = new LdAiClient(mockClient.Object);
42-
var tracker = client.ModelConfig("foo", context, LdAiConfig.Disabled, variables);
42+
var tracker = client.Config("foo", context, LdAiConfig.Disabled, variables);
4343

4444
return tracker.Config.Messages[0].Content;
4545
}
@@ -146,7 +146,7 @@ public void TestInterpolationMalformed()
146146
mockLogger.Setup(x => x.Error(It.IsAny<string>()));
147147

148148
var client = new LdAiClient(mockClient.Object);
149-
var tracker = client.ModelConfig("foo", Context.New("key"), LdAiConfig.Disabled);
149+
var tracker = client.Config("foo", Context.New("key"), LdAiConfig.Disabled);
150150
Assert.False(tracker.Config.Enabled);
151151
}
152152

pkgs/sdk/server-ai/test/LdAiClientTest.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public void CanInstantiateWithServerSideClient()
1616
{
1717
var client = new LdClientAdapter(new LdClient(Configuration.Builder("key").Offline(true).Build()));
1818
var aiClient = new LdAiClient(client);
19-
var result= aiClient.ModelConfig("foo", Context.New("key"), LdAiConfig.Disabled);
19+
var result= aiClient.Config("foo", Context.New("key"), LdAiConfig.Disabled);
2020
Assert.False(result.Config.Enabled);
2121
}
2222

@@ -44,7 +44,7 @@ public void ReturnsDefaultConfigWhenGivenInvalidVariation()
4444

4545
var defaultConfig = LdAiConfig.New().AddMessage("Hello").Build();
4646

47-
var tracker = client.ModelConfig("foo", Context.New(ContextKind.Default, "key"), defaultConfig);
47+
var tracker = client.Config("foo", Context.New(ContextKind.Default, "key"), defaultConfig);
4848

4949
Assert.Equal(defaultConfig, tracker.Config);
5050
}
@@ -95,7 +95,7 @@ public void ConfigNotEnabledReturnsDisabledInstance(string json)
9595
// All the JSON inputs here are considered disabled, either due to lack of the 'enabled' property,
9696
// or if present, it is set to false. Therefore, if the default was returned, we'd see the assertion fail
9797
// (since calling LdAiConfig.New() constructs an enabled config by default.)
98-
var tracker = client.ModelConfig("foo", Context.New(ContextKind.Default, "key"),
98+
var tracker = client.Config("foo", Context.New(ContextKind.Default, "key"),
9999
LdAiConfig.New().AddMessage("foo").Build());
100100

101101
Assert.False(tracker.Config.Enabled);
@@ -115,7 +115,7 @@ public void CanSetAllDefaultValueFields()
115115

116116
var client = new LdAiClient(mockClient.Object);
117117

118-
var tracker = client.ModelConfig("foo", Context.New(ContextKind.Default, "key"),
118+
var tracker = client.Config("foo", Context.New(ContextKind.Default, "key"),
119119
LdAiConfig.New().
120120
AddMessage("foo").
121121
SetModelParam("foo", LdValue.Of("bar")).
@@ -158,7 +158,7 @@ public void ConfigEnabledReturnsInstance()
158158
var client = new LdAiClient(mockClient.Object);
159159

160160
// We shouldn't get this default.
161-
var tracker = client.ModelConfig("foo", context,
161+
var tracker = client.Config("foo", context,
162162
LdAiConfig.New().AddMessage("Goodbye!").Build());
163163

164164
Assert.Collection(tracker.Config.Messages,
@@ -210,7 +210,7 @@ public void ModelParametersAreParsed()
210210
var client = new LdAiClient(mockClient.Object);
211211

212212
// We shouldn't get this default.
213-
var tracker = client.ModelConfig("foo", context,
213+
var tracker = client.Config("foo", context,
214214
LdAiConfig.New().AddMessage("Goodbye!").Build());
215215

216216
Assert.Equal("model-foo", tracker.Config.Model.Id);
@@ -247,7 +247,7 @@ public void ProviderConfigIsParsed()
247247
var client = new LdAiClient(mockClient.Object);
248248

249249
// We shouldn't get this default.
250-
var tracker = client.ModelConfig("foo", context,
250+
var tracker = client.Config("foo", context,
251251
LdAiConfig.New().AddMessage("Goodbye!").Build());
252252

253253
Assert.Equal("amazing-provider", tracker.Config.Provider.Id);

0 commit comments

Comments
 (0)