test: add unit test for handling identify failure before initialization

This commit will also fix this issue

Author: joker23

packages/sdk/browser/__tests__/BrowserClient.test.ts

@@ -463,4 +463,42 @@ describe('given a mock platform for a BrowserClient', () => {
       error: identifyError,
     });
   });
+
+  it('resolves waitForInitialization with failed status when identify fails before waitForInitialization is called', async () => {
+    const errorPlatform = makeBasicPlatform();
+    const identifyError = new Error('Network error');
+
+    // Mock fetch to reject with an error
+    errorPlatform.requests.fetch = jest.fn((_url: string, _options: any) =>
+      Promise.reject(identifyError),
+    ) as any;
+
+    const client = makeClient(
+      'client-side-id',
+      AutoEnvAttributes.Disabled,
+      { streaming: false, logger, diagnosticOptOut: true, sendEvents: false, fetchGoals: false },
+      errorPlatform,
+    );
+
+    // Start identify which will fail BEFORE waitForInitialization is called
+    const identifyPromise = client.identify({ key: 'user-key', kind: 'user' });
+
+    await jest.advanceTimersByTimeAsync(4000); // trigger all poll retries
+
+    // Wait for identify to fail
+    await expect(identifyPromise).resolves.toEqual({
+      status: 'error',
+      error: identifyError,
+    });
+
+    // Now call waitForInitialization AFTER identify has already failed
+    // It should return the failed status immediately, not timeout
+    const waitPromise = client.waitForInitialization({ timeout: 10 });
+
+    // Verify that waitForInitialization returns immediately with failed status
+    await expect(waitPromise).resolves.toEqual({
+      status: 'failed',
+      error: identifyError,
+    });
+  });
 });

packages/sdk/browser/src/BrowserClient.ts

@@ -42,7 +42,7 @@ class BrowserClientImpl extends LDClientImpl {
   private readonly _plugins?: LDPlugin[];
   private _initializedPromise?: Promise<LDWaitForInitializationResult>;
   private _initResolve?: (result: LDWaitForInitializationResult) => void;
-  private _isInitialized: boolean = false;
+  private _initializeResult?: LDWaitForInitializationResult;
 
   constructor(
     clientSideId: string,
@@ -224,10 +224,11 @@ class BrowserClientImpl extends LDClientImpl {
     }
     const res = await super.identifyResult(context, identifyOptionsWithUpdatedDefaults);
     if (res.status === 'completed') {
-      this._isInitialized = true;
-      this._initResolve?.({ status: 'complete' });
+      this._initializeResult = { status: 'complete' };
+      this._initResolve?.(this._initializeResult);
     } else if (res.status === 'error') {
-      this._initResolve?.({ status: 'failed', error: res.error });
+      this._initializeResult = { status: 'failed', error: res.error };
+      this._initResolve?.(this._initializeResult);
     }
 
     this._goalManager?.startTracking();
@@ -250,10 +251,9 @@ class BrowserClientImpl extends LDClientImpl {
       return this._promiseWithTimeout(this._initializedPromise, timeout);
     }
 
-    if (this._isInitialized) {
-      return Promise.resolve({
-        status: 'complete',
-      });
+    // If initialization has already completed (successfully or failed), return the result immediately
+    if (this._initializeResult) {
+      return Promise.resolve(this._initializeResult);
     }
 
     if (!this._initializedPromise) {