From 74a8f8b74f1b056146869df10e81bf4a1849a32d Mon Sep 17 00:00:00 2001 From: Louis Chan Date: Thu, 29 May 2025 16:17:00 -0700 Subject: [PATCH 1/2] chore: updating identify code documentation --- typings.d.ts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/typings.d.ts b/typings.d.ts index ba882f1..263d9e3 100644 --- a/typings.d.ts +++ b/typings.d.ts @@ -1071,6 +1071,13 @@ export interface LDPlugin { * Changing the current context also causes all feature flag values to be reloaded. Until that has * finished, calls to {@link variation} will still return flag values for the previous context. You can * use a callback or a Promise to determine when the new flag values are available. + * + * It is possible that the identify call fails. In that case, when using a callback, the callback will receive + * an error value. While the SDK will continue to function, developer will need to be aware that + * calls to {@link variation} will still return flag values for the previous context. + * + * When using a promise, it is important that you handle the rejection case; + * otherwise it will become an unhandled Promise rejection, which is a serious error on some platforms. * * @param context * The context properties. Must contain at least the `key` property. From 79c750d9991e6228046060fca653a22f3024aa49 Mon Sep 17 00:00:00 2001 From: Alan Barker Date: Fri, 30 May 2025 15:10:15 -0400 Subject: [PATCH 2/2] chore: updating wording of identify code documentation --- typings.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/typings.d.ts b/typings.d.ts index 263d9e3..6484457 100644 --- a/typings.d.ts +++ b/typings.d.ts @@ -1072,8 +1072,8 @@ export interface LDPlugin { * finished, calls to {@link variation} will still return flag values for the previous context. You can * use a callback or a Promise to determine when the new flag values are available. * - * It is possible that the identify call fails. In that case, when using a callback, the callback will receive - * an error value. While the SDK will continue to function, developer will need to be aware that + * It is possible that the identify call will fail. In that case, when using a callback, the callback will receive + * an error value. While the SDK will continue to function, the developer will need to be aware that * calls to {@link variation} will still return flag values for the previous context. * * When using a promise, it is important that you handle the rejection case;