Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldcli dev-server "Remove all overrides" doesn't trigger change event #452

Closed
CodeOfficer opened this issue Oct 23, 2024 · 1 comment · Fixed by #455
Closed

ldcli dev-server "Remove all overrides" doesn't trigger change event #452

CodeOfficer opened this issue Oct 23, 2024 · 1 comment · Fixed by #455

Comments

@CodeOfficer
Copy link

CodeOfficer commented Oct 23, 2024

Describe the bug

With ldcli dev-server fired up, clicking "Remove all overrides" doesn't trigger a change event to connected clients.

To reproduce

  • Connect clients to dev-server
  • Toggle single boolean flag
  • Observe change event streamed to connected clients
  • Click "Remove all overrides"
  • Observe no change event streamed to connected clients

Expected behavior

  • "Remove all overrides" should stream change event to connected clients

Logs

launchdevly-1  | 2024/10/23 15:51:00 Notify: event {FlagKey:ai-enabled ProjectKey:auditboard FlagState:{Value:false Version:10}} to observers
launchdevly-1  | 2024/10/23 15:51:00 serverFlagsObserver: handling flag state event: {ai-enabled auditboard {false 10}}
launchdevly-1  | 2024/10/23 15:51:00 serverFlagsObserver: handling flag state event: {ai-enabled auditboard {false 10}}
launchdevly-1  | 2024/10/23 15:51:00 clientFlagsObserver: handling flag state event: {ai-enabled auditboard {false 10}}
launchdevly-1  | 192.168.65.1 - - [23/Oct/2024:15:51:00 +0000] "PUT /dev/projects/auditboard/overrides/ai-enabled HTTP/1.1" 200 32 "http://localhost:8765/ui/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36"
launchdevly-1  | 192.168.65.1 - - [23/Oct/2024:15:51:02 +0000] "POST /events/bulk/auditboard HTTP/1.1" 202 0 "http://localhost:9002/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36"
launchdevly-1  | 192.168.65.1 - - [23/Oct/2024:15:51:03 +0000] "DELETE /dev/projects/auditboard/overrides/ai-enabled HTTP/1.1" 204 0 "http://localhost:8765/ui/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36"

CLI version

ldcli version 1.8.0

OS/platform

  • MacOS 14.6.1
  • Chrome Version 129.0.6668.103 (Official Build) (arm64)

Additional context

image
@mike-zorn
Copy link
Contributor

Should be fixed in 1.8.1! Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants