From 49ee6a57cf139d7e15e45821aff994fa5a527bda Mon Sep 17 00:00:00 2001 From: Matthew Keeler Date: Mon, 12 Aug 2024 13:28:48 -0400 Subject: [PATCH 1/4] Update LD actions --- .github/workflows/manual-publish.yml | 2 +- .github/workflows/release-please.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/manual-publish.yml b/.github/workflows/manual-publish.yml index b2a862d..661b838 100644 --- a/.github/workflows/manual-publish.yml +++ b/.github/workflows/manual-publish.yml @@ -24,7 +24,7 @@ jobs: - name: Install poetry run: pipx install poetry - - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.0.2 + - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.2.0 name: 'Get PyPI token' with: aws_assume_role: ${{ vars.AWS_ROLE_ARN }} diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index 74740be..cd3315e 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -33,7 +33,7 @@ jobs: if: ${{ steps.release.outputs.releases_created }} run: pipx install poetry - - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.0.2 + - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.2.0 if: ${{ steps.release.outputs.releases_created }} name: 'Get PyPI token' with: From 3a38dc35c4b621d13bd54bb34394d21c987ab8ba Mon Sep 17 00:00:00 2001 From: Matthew Keeler Date: Mon, 12 Aug 2024 13:29:16 -0400 Subject: [PATCH 2/4] Update release-please --- .github/workflows/release-please.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index cd3315e..a543a8c 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -12,12 +12,8 @@ jobs: contents: write # Contents and pull-requests are for release-please to make releases. pull-requests: write steps: - - uses: google-github-actions/release-please-action@v3 + - uses: googleapis/release-please-action@v4 id: release - with: - command: manifest - token: ${{secrets.GITHUB_TOKEN}} - default-branch: main - uses: actions/checkout@v4 if: ${{ steps.release.outputs.releases_created }} From c9e14cbc4063b0537204dc8b63d7ffaeef68b3b1 Mon Sep 17 00:00:00 2001 From: Matthew Keeler Date: Mon, 12 Aug 2024 13:36:14 -0400 Subject: [PATCH 3/4] Bump setup-python --- .github/workflows/ci.yml | 4 ++-- .github/workflows/manual-publish.yml | 2 +- .github/workflows/release-please.yml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2018bac..2f57e6b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,7 +21,7 @@ jobs: steps: - uses: actions/checkout@v4 - name: Set up Python ${{ matrix.python-version }} - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: ${{ matrix.python-version }} @@ -51,7 +51,7 @@ jobs: steps: - uses: actions/checkout@v4 - name: Set up Python ${{ matrix.python-version }} - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: ${{ matrix.python-version }} diff --git a/.github/workflows/manual-publish.yml b/.github/workflows/manual-publish.yml index 661b838..aea5895 100644 --- a/.github/workflows/manual-publish.yml +++ b/.github/workflows/manual-publish.yml @@ -17,7 +17,7 @@ jobs: steps: - uses: actions/checkout@v4 - - uses: actions/setup-python@v4 + - uses: actions/setup-python@v5 with: python-version: 3.8 diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index a543a8c..d6c4b7e 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -20,7 +20,7 @@ jobs: with: fetch-depth: 0 # If you only need the current version keep this. - - uses: actions/setup-python@v4 + - uses: actions/setup-python@v5 if: ${{ steps.release.outputs.releases_created }} with: python-version: 3.8 From f9d8d55904b2835e2c13419d018ce0e7fc5245b4 Mon Sep 17 00:00:00 2001 From: Matthew Keeler Date: Mon, 12 Aug 2024 16:12:36 -0400 Subject: [PATCH 4/4] Fix comparison --- .github/workflows/release-please.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index d6c4b7e..81a9b89 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -16,34 +16,34 @@ jobs: id: release - uses: actions/checkout@v4 - if: ${{ steps.release.outputs.releases_created }} + if: ${{ steps.release.outputs.releases_created == 'true' }} with: fetch-depth: 0 # If you only need the current version keep this. - uses: actions/setup-python@v5 - if: ${{ steps.release.outputs.releases_created }} + if: ${{ steps.release.outputs.releases_created == 'true' }} with: python-version: 3.8 - name: Install poetry - if: ${{ steps.release.outputs.releases_created }} + if: ${{ steps.release.outputs.releases_created == 'true' }} run: pipx install poetry - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.2.0 - if: ${{ steps.release.outputs.releases_created }} + if: ${{ steps.release.outputs.releases_created == 'true' }} name: 'Get PyPI token' with: aws_assume_role: ${{ vars.AWS_ROLE_ARN }} ssm_parameter_pairs: '/production/common/releasing/pypi/token = PYPI_AUTH_TOKEN' - uses: ./.github/actions/build - if: ${{ steps.release.outputs.releases_created }} + if: ${{ steps.release.outputs.releases_created == 'true' }} - uses: ./.github/actions/build-docs - if: ${{ steps.release.outputs.releases_created }} + if: ${{ steps.release.outputs.releases_created == 'true' }} - uses: ./.github/actions/publish - if: ${{ steps.release.outputs.releases_created }} + if: ${{ steps.release.outputs.releases_created == 'true' }} with: token: ${{env.PYPI_AUTH_TOKEN}} dry_run: false