Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracting placements from specified clades #31

Closed
mjamy opened this issue Feb 13, 2025 · 2 comments
Closed

Extracting placements from specified clades #31

mjamy opened this issue Feb 13, 2025 · 2 comments

Comments

@mjamy
Copy link

mjamy commented Feb 13, 2025

Hi Lucas!

Hope you're doing well!

I have a (hopefully quick) question about extracting placements from clades using the subcommand extract.

I'm a bit confused about whether gappa extracts placements from the stem branch of the clade as well or not. To illustrate, I'm attaching an image comparing my output (using the flag --color-tree-file) to the figure from your 2017 NEE paper with "Radiozoa" highlighted. If I understand your study correctly, OTUs placed in the stem branches (highlighted in grey) were discarded. I'm wondering how I can replicate the analysis, as it seems placements on the stem Radiozoa branch would be included in my case.

Image

Thanks a lot!

Mahwash

@lczech
Copy link
Owner

lczech commented Feb 18, 2025

Hi Mahwash,

good point, that indeed was not possible with the command, and differed from the way we did it in the article. Luckily, I had already implemented the functionality, and just not exposed it via the command line interface of gappa, so that was quick to fix.

The new release gappa v0.9.0 now contains an option --exclude-clade-stems to do what you want. I've also renamed the basal_branches output of the command to simply basal, but also added options to rename that and the uncertain clade. And I've moved the command to the edit module, which seemed more fitting - as you were not aware of that command as well, I guess it was not very findable where it was before, and I hope that helps.

Closing the issue for now, but let me know if that works for you, or if you have any more trouble or suggestions :-)

Cheers
Lucas

@lczech lczech closed this as completed Feb 18, 2025
@mjamy
Copy link
Author

mjamy commented Feb 18, 2025

Wow thanks Lucas for the very quick fix and thorough response!!

I'll try it and let you know if I run into trouble. I expect it will go smoothly though ;)

Cheers,
Mahwash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants