Skip to content

Commit 8d4879d

Browse files
committed
[LDC] PGO: Avoid COMDAT members with private linkage for Windows
To prevent according IR verifier errors with IR-based PGO ('comdat global value has private linkage').
1 parent 1618a2a commit 8d4879d

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

llvm/lib/ProfileData/InstrProf.cpp

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -323,8 +323,13 @@ GlobalVariable *createPGOFuncNameVar(Module &M,
323323
else if (Linkage == GlobalValue::AvailableExternallyLinkage)
324324
Linkage = GlobalValue::LinkOnceODRLinkage;
325325
else if (Linkage == GlobalValue::InternalLinkage ||
326-
Linkage == GlobalValue::ExternalLinkage)
327-
Linkage = GlobalValue::PrivateLinkage;
326+
Linkage == GlobalValue::ExternalLinkage) {
327+
// LDC: use internal instead of private linkage for COFF (still local, but
328+
// allows for COMDATs on Windows)
329+
Linkage = Triple(M.getTargetTriple()).isOSBinFormatCOFF()
330+
? GlobalValue::InternalLinkage
331+
: GlobalValue::PrivateLinkage;
332+
}
328333

329334
auto *Value =
330335
ConstantDataArray::getString(M.getContext(), PGOFuncName, false);

0 commit comments

Comments
 (0)