feat(Topology/Algebra): inv and div for infinite products over groups with zero#40591
feat(Topology/Algebra): inv and div for infinite products over groups with zero#40591ajirving wants to merge 10 commits into
Conversation
PR summary 3c6d1ffe9e
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Topology.Algebra.InfiniteSum.Group | 1154 | 1155 | +1 (+0.09%) |
Import changes for all files
| Files | Import difference |
|---|---|
6 filesMathlib.Topology.Algebra.InfiniteSum.Constructions Mathlib.Topology.Algebra.InfiniteSum.DiscreteConvolution Mathlib.Topology.Algebra.InfiniteSum.GroupCompletion Mathlib.Topology.Algebra.InfiniteSum.Group Mathlib.Topology.Algebra.InfiniteSum.Module Mathlib.Topology.Algebra.InfiniteSum.NatInt |
1 |
Declarations diff (regex)
+ HasProd.div₀
+ HasProd.inv₀
+ Multipliable.div₀
+ Multipliable.inv₀
+ Multipliable.tprod_div₀
+ Multipliable.tprod_inv₀
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean)
✅ Lean-aware diff — post-build, computed from the Lean environment (commit
3c6d1ff).
- +6 new declarations
- −0 removed declarations
+HasProd.div₀
+HasProd.inv₀
+Multipliable.div₀
+Multipliable.inv₀
+Multipliable.tprod_div₀
+Multipliable.tprod_inv₀No changes to strong technical debt.
No changes to weak technical debt.
Current commit 3c6d1ffe9e
Reference commit c026161a58
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
✅ PR Title Formatted CorrectlyThe title of this PR has been updated to match our commit style conventions. |
|
Can you generalize these lemmas to an arbitrary |
Co-authored-by: Aaron Liu <aaronliu2008@outlook.com>
Thanks, I've done that now. |
scholzhannah
left a comment
There was a problem hiding this comment.
Thank you for your PR! I have left two superficial comments but I don't know anything about this area so I'll unassign myself.
Co-authored-by: Hannah Scholz <70071345+scholzhannah@users.noreply.github.com>
Co-authored-by: Hannah Scholz <70071345+scholzhannah@users.noreply.github.com>
j-loreaux
left a comment
There was a problem hiding this comment.
Can you please add the associated lemmas for Multipliable and tprod?
|
-awaiting-author I've added Multipliable and tprod variants. |
| obtain ⟨s, hs⟩ : ∃ s : Finset α, ∀ i ∉ s, f i = g i := ⟨hfg.toFinset, by simp⟩ | ||
| exact (hc.congr_cofinite₀ (fun a _ ↦ hf' a) hs).multipliable | ||
|
|
||
| omit [SeparatelyContinuousMul K] in |
There was a problem hiding this comment.
Instead of omitting this everywhere, just out that variable in its own section for the results above.
|
✌️ ajirving can now approve this pull request until 2026-08-06 02:36 UTC (in 2 weeks). To approve and merge, reply with
|
Proves two lemmas for infinite products over groups with zero: inverses and division behave as expected provided the limit is nonzero. This requires an extra import to get some of the GroupWithZero API. Maybe the GroupWithZero results should be in a different file but I was just adding to what was already there in Group.lean.