Skip to content

[Merged by Bors] - chore(Data/Set): add missing Set.forall_mem_* lemmas - #42549

Closed
plp127 wants to merge 5 commits into
leanprover-community:masterfrom
plp127:aliu/forall_mem_
Closed

[Merged by Bors] - chore(Data/Set): add missing Set.forall_mem_* lemmas#42549
plp127 wants to merge 5 commits into
leanprover-community:masterfrom
plp127:aliu/forall_mem_

Conversation

@plp127

@plp127 plp127 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Add lemmas Set.forall_mem_inter, Set.forall_mem_union, Set.forall_mem_singleton, Set.forall_mem_univ, Set.forall_mem_iUnion, Set.forall_mem_iUnion₂, Set.forall_mem_biUnion, and their exists counterparts.


Open in Gitpod

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

PR summary 762e11aa2a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ Nonempty.exists_const
+ exists_mem_biUnion
+ exists_mem_const
+ exists_mem_empty
+ exists_mem_iUnion
+ exists_mem_iUnion₂
+ exists_mem_inter
+ exists_mem_ofPred
+ exists_mem_singleton
+ exists_mem_union
+ exists_mem_univ
+ forall_mem_biUnion
+ forall_mem_iUnion
+ forall_mem_iUnion₂
+ forall_mem_inter
+ forall_mem_ofPred
+ forall_mem_singleton
+ forall_mem_union
+ forall_mem_univ

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 762e11a).

  • +19 new declarations
  • −0 removed declarations
+Set.Nonempty.exists_const
+Set.exists_mem_biUnion
+Set.exists_mem_const
+Set.exists_mem_empty
+Set.exists_mem_iUnion
+Set.exists_mem_iUnion₂
+Set.exists_mem_inter
+Set.exists_mem_ofPred
+Set.exists_mem_singleton
+Set.exists_mem_union
+Set.exists_mem_univ
+Set.forall_mem_biUnion
+Set.forall_mem_iUnion
+Set.forall_mem_iUnion₂
+Set.forall_mem_inter
+Set.forall_mem_ofPred
+Set.forall_mem_singleton
+Set.forall_mem_union
+Set.forall_mem_univ

No changes to strong technical debt.

Increase in weak tech debt: (relative, absolute) = (1.00, 0.20)
Current number Change Type (weak)
5 1 large files

Current commit 762e11aa2a
Reference commit ac10dc7e9a

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-data Data (lists, quotients, numbers, etc) label Aug 7, 2026

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 16, 2026
Comment thread Mathlib/Data/Set/Basic.lean
Comment thread Mathlib/Data/Set/Basic.lean
Comment thread Mathlib/Data/Set/Insert.lean
@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Aug 16, 2026
@j-loreaux j-loreaux self-assigned this Aug 16, 2026
@plp127 plp127 removed the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 16, 2026
@j-loreaux

Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Aug 16, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Aug 16, 2026
Add lemmas `Set.forall_mem_inter`, `Set.forall_mem_union`, `Set.forall_mem_singleton`, `Set.forall_mem_univ`, `Set.forall_mem_iUnion`, `Set.forall_mem_iUnion₂`, `Set.forall_mem_biUnion`, and their `exists` counterparts.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Aug 16, 2026
@mathlib-bors

mathlib-bors Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title chore(Data/Set): add missing Set.forall_mem_* lemmas [Merged by Bors] - chore(Data/Set): add missing Set.forall_mem_* lemmas Aug 16, 2026
@mathlib-bors mathlib-bors Bot closed this Aug 16, 2026
@plp127
plp127 deleted the aliu/forall_mem_ branch August 16, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants