Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nat.not_eq_zero_of_lt should be called Nat.ne_zero_of_lt #6714

Open
3 tasks done
Ruben-VandeVelde opened this issue Jan 20, 2025 · 0 comments
Open
3 tasks done

Nat.not_eq_zero_of_lt should be called Nat.ne_zero_of_lt #6714

Ruben-VandeVelde opened this issue Jan 20, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@Ruben-VandeVelde
Copy link

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

The lemma Nat.not_eq_zero_of_lt should be called Nat.ne_zero_of_lt since its conclusion is Ne:

theorem not_eq_zero_of_lt (h : b < a) : a ≠ 0 := by

Context

This would make it consistent with mathlib's _root_.ne_zero_of_lt; Zulip discussion. It should probably also be protected.

Steps to Reproduce

Expected behavior: [Clear and concise description of what you expect to happen]

Actual behavior: [Clear and concise description of what actually happens]

Versions

Verified on commit 128a1e6; added in commit dae3489.

Additional Information

[Additional information, configuration or data that might be necessary to reproduce the issue]

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

@Ruben-VandeVelde Ruben-VandeVelde added the bug Something isn't working label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant