We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please put an X between the brackets as you perform the following steps:
The lemma Nat.not_eq_zero_of_lt should be called Nat.ne_zero_of_lt since its conclusion is Ne:
Nat.not_eq_zero_of_lt
Nat.ne_zero_of_lt
Ne
theorem not_eq_zero_of_lt (h : b < a) : a ≠ 0 := by
This would make it consistent with mathlib's _root_.ne_zero_of_lt; Zulip discussion. It should probably also be protected.
_root_.ne_zero_of_lt
Expected behavior: [Clear and concise description of what you expect to happen]
Actual behavior: [Clear and concise description of what actually happens]
Verified on commit 128a1e6; added in commit dae3489.
[Additional information, configuration or data that might be necessary to reproduce the issue]
Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Prerequisites
Please put an X between the brackets as you perform the following steps:
https://github.com/leanprover/lean4/issues
Avoid dependencies to Mathlib or Batteries.
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)
Description
The lemma
Nat.not_eq_zero_of_lt
should be calledNat.ne_zero_of_lt
since its conclusion isNe
:Context
This would make it consistent with mathlib's
_root_.ne_zero_of_lt
; Zulip discussion. It should probably also be protected.Steps to Reproduce
Expected behavior: [Clear and concise description of what you expect to happen]
Actual behavior: [Clear and concise description of what actually happens]
Versions
Verified on commit 128a1e6; added in commit dae3489.
Additional Information
[Additional information, configuration or data that might be necessary to reproduce the issue]
Impact
Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.
The text was updated successfully, but these errors were encountered: