Skip to content

Commit 95c4229

Browse files
committed
* Add SECoreTextView to the project so we can take UIWebView out of the table, where it is notoriously ill-suited to be.
1 parent 0accf24 commit 95c4229

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+5550
-1267
lines changed

Lemacs.xcworkspace/xcshareddata/Lemacs.xccheckout

+12
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,17 @@
1010
<dict>
1111
<key>863AE0E5-FEAF-456F-983C-5F77159CFE5C</key>
1212
<string>https://github.com/lemurs/Lemacs.git</string>
13+
<key>A15FA6FB-3B35-4F14-B88A-9929359A7C43</key>
14+
<string>git://github.com/twitter/twitter-text-conformance.git</string>
1315
</dict>
1416
<key>IDESourceControlProjectPath</key>
1517
<string>Lemacs.xcworkspace</string>
1618
<key>IDESourceControlProjectRelativeInstallPathDictionary</key>
1719
<dict>
1820
<key>863AE0E5-FEAF-456F-983C-5F77159CFE5C</key>
1921
<string>..</string>
22+
<key>A15FA6FB-3B35-4F14-B88A-9929359A7C43</key>
23+
<string>../Pods/SECoreTextView/Vendor/twitter-text-objc/test/twitter-text-conformance</string>
2024
</dict>
2125
<key>IDESourceControlProjectURL</key>
2226
<string>https://github.com/lemurs/Lemacs.git</string>
@@ -34,6 +38,14 @@
3438
<key>IDESourceControlWCCName</key>
3539
<string>Lemacs</string>
3640
</dict>
41+
<dict>
42+
<key>IDESourceControlRepositoryExtensionIdentifierKey</key>
43+
<string>public.vcs.git</string>
44+
<key>IDESourceControlWCCIdentifierKey</key>
45+
<string>A15FA6FB-3B35-4F14-B88A-9929359A7C43</string>
46+
<key>IDESourceControlWCCName</key>
47+
<string>twitter-text-conformance</string>
48+
</dict>
3749
</array>
3850
</dict>
3951
</plist>

Lemacs/LETalkListController.m

+12
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,17 @@ - (void)configureCell:(UITableViewCell *)cell atIndexPath:(NSIndexPath *)indexPa
2929

3030
@implementation LETalkListController
3131

32+
#pragma mark NSObject (NSKeyValueObserving)
33+
34+
- (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(NSDictionary *)change context:(void *)context;
35+
{
36+
if ([keyPath isEqual:@"preferredHeight"])
37+
[self.tableView reloadData];
38+
else if ([super respondsToSelector:@selector(observeValueForKeyPath:ofObject:change:context:)])
39+
[super observeValueForKeyPath:keyPath ofObject:object change:change context:context];
40+
}
41+
42+
3243
#pragma mark - NSObject (UINibLoadingAdditions)
3344

3445
- (void)awakeFromNib;
@@ -342,6 +353,7 @@ - (void)configureCell:(UITableViewCell *)cell atIndexPath:(NSIndexPath *)indexPa
342353
id <LETalk> talk = [self.fetchedResultsController objectAtIndexPath:indexPath];
343354
assert([talk conformsToProtocol:@protocol(LETalk)]);
344355

356+
[talkCell addObserver:self forKeyPath:@"preferredHeight" options:NSKeyValueObservingOptionNew context:NULL];
345357

346358
[self.talkURLsToCells setObject:talkCell forKey:talk.baseURL];
347359
[talkCell configureCellWithTalk:talk];

Podfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ xcodeproj 'Lemacs.xcodeproj'
33
pod 'UAGithubEngine'
44
pod 'UICKeyChainStore'
55
pod 'HockeySDK'
6+
pod 'SECoreTextView', :git => 'https://github.com/kishikawakatsumi/SECoreTextView.git'
67
pod 'sundown', '~> 0.1.0'
7-

Podfile.lock

+7
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,24 @@
11
PODS:
22
- HockeySDK (3.0.0)
3+
- SECoreTextView (1.0.0)
34
- sundown (0.1.0)
45
- UAGithubEngine (2.3)
56
- UICKeyChainStore (1.0.2)
67

78
DEPENDENCIES:
89
- HockeySDK
10+
- SECoreTextView (from `https://github.com/kishikawakatsumi/SECoreTextView.git`)
911
- sundown (~> 0.1.0)
1012
- UAGithubEngine
1113
- UICKeyChainStore
1214

15+
EXTERNAL SOURCES:
16+
SECoreTextView:
17+
:git: https://github.com/kishikawakatsumi/SECoreTextView.git
18+
1319
SPEC CHECKSUMS:
1420
HockeySDK: 286d86c6e89a35de7f3e4f3c2879a07185ee0918
21+
SECoreTextView: f87af11c421bb0e220c422474c27e4205c7d4ee8
1522
sundown: f0b86bd08ee36f84e9e6a6332d3cbd0309889dfa
1623
UAGithubEngine: 931cbfaaec42ee192dfecf9aeaa75bd4e1afc595
1724
UICKeyChainStore: 6f207688b1310e9b9d879c1ee702f5b0eb9484f8

Pods/BuildHeaders/SECoreTextView/NSMutableAttributedString+Helper.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/BuildHeaders/SECoreTextView/SECompatibility.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/BuildHeaders/SECoreTextView/SEConstants.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/BuildHeaders/SECoreTextView/SELineLayout.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/BuildHeaders/SECoreTextView/SELinkText.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/BuildHeaders/SECoreTextView/SESelectionGrabber.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/BuildHeaders/SECoreTextView/SETextAttachment.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/BuildHeaders/SECoreTextView/SETextGeometry.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/BuildHeaders/SECoreTextView/SETextLayout.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/BuildHeaders/SECoreTextView/SETextMagnifierCaret.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/BuildHeaders/SECoreTextView/SETextMagnifierRanged.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/BuildHeaders/SECoreTextView/SETextSelection.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/BuildHeaders/SECoreTextView/SETextView.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Headers/SECoreTextView/NSMutableAttributedString+Helper.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Headers/SECoreTextView/SECompatibility.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Headers/SECoreTextView/SEConstants.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Headers/SECoreTextView/SELineLayout.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Headers/SECoreTextView/SELinkText.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Headers/SECoreTextView/SESelectionGrabber.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Headers/SECoreTextView/SETextAttachment.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Headers/SECoreTextView/SETextGeometry.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Headers/SECoreTextView/SETextLayout.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Headers/SECoreTextView/SETextMagnifierCaret.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Headers/SECoreTextView/SETextMagnifierRanged.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Headers/SECoreTextView/SETextSelection.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Headers/SECoreTextView/SETextView.h

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Local Podspecs/SECoreTextView.podspec

+15
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Pods-HockeySDK-Private.xcconfig

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Pods-SECoreTextView-Private.xcconfig

+5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Pods-SECoreTextView-dummy.m

+5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Pods-SECoreTextView-prefix.pch

+5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Pods-SECoreTextView.xcconfig

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Pods-UAGithubEngine-Private.xcconfig

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Pods-UICKeyChainStore-Private.xcconfig

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Pods-acknowledgements.markdown

+23

Pods/Pods-acknowledgements.plist

+27
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Pods-environment.h

+6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Pods-resources.sh

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Pods-sundown-Private.xcconfig

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Pods/Pods.xcconfig

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)