Skip to content

Expose types in package.json #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mybearworld opened this issue Mar 16, 2024 · 4 comments · Fixed by #192
Closed

Expose types in package.json #191

mybearworld opened this issue Mar 16, 2024 · 4 comments · Fixed by #192

Comments

@mybearworld
Copy link
Contributor

mybearworld commented Mar 16, 2024

Leopard is written in Typescript, and the type definitions are already part of the Leopard package. However, they aren't actually set in the package.json, so Typescript doesn't see them.

    "main": "dist/index.umd.js",
    "module": "dist/index.esm.js",
+   "types": "dist/index.d.ts",
@towerofnix
Copy link
Member

@adroitwhiz Pinging you for attention on this, is that all there is to providing Leopard's types to package consumers (what I'm assuming this issue is about)? Pretty much normal for TypeScript projects, no additional changes needed?

@adroitwhiz
Copy link
Collaborator

Yup, pretty much.

@towerofnix
Copy link
Member

@mybearworld Would you like to make a pull request? 👾✨

@mybearworld
Copy link
Contributor Author

Sure, I made one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants