Skip to content

Commit e6f8e3f

Browse files
authored
Merge pull request #58 from letsgamedev/closing_condition
Add Closing conditions for pull requests
2 parents e1567b3 + 642121f commit e6f8e3f

File tree

1 file changed

+23
-1
lines changed

1 file changed

+23
-1
lines changed

CONTRIBUTING.md

+23-1
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,47 @@
11
# Contributing to Suffragium
2+
23
There are many ways, how you can contribute and be part of this project.
34

45
The most meaningful are:
6+
57
- Open a pull request
68
- Vote
79
- Give feedback
10+
811
---
12+
913
## Open a Pull Request
10-
If you want to add a feature or fix a bug. Pull Requests are the way to go. Try to keep them short and simple and follow the developer guide.
14+
15+
If you want to add a feature or fix a bug. Pull Requests are the way to go. Try to keep them short and simple and follow the developer guide.
16+
1117
### Developer guide
18+
1219
#### REQUIRED
20+
1321
- Follow the [GDScript style guide](https://docs.godotengine.org/en/stable/tutorials/scripting/gdscript/gdscript_styleguide.html#gdscript-style-guide)
1422
- Use [Scony"s godot gdscript tollkit](https://github.com/Scony/godot-gdscript-toolkit/) to validate the Pull Request
23+
1524
#### RECOMMENDED
25+
1626
- Folder names are in snake_case
1727
- File names are in snake_case
1828
- Node names are in PascalCase
29+
1930
---
31+
2032
## How to Vote
33+
2134
Place a :+1: or :-1: emoji on the initial post of an pull request. When the merge conditions are met, the pull request will be merged.
35+
2236
## Merge pull request conditions
37+
2338
If one of them is true, the PR will me merged.
39+
2440
- **Last commit is 24h or older** and **has more than 10 votes** and **75% positive votes**
2541
- **Last commit is 72h or older** and **75% positive votes**
42+
43+
## Close pull request without merging conditions
44+
45+
If its true, the pull request / draft is considered as blocked and will be closed
46+
47+
- **Last commit is 20 days or older**

0 commit comments

Comments
 (0)