Merge pull request #16 from leviy/allow-useful-annotations

nicwortel · web-flow · commit 01a44199bb85 · 2018-11-09T14:10:25.000+01:00
Allow all usefull annotations
diff --git a/composer.json b/composer.json
@@ -14,7 +14,7 @@
         "dealerdirect/phpcodesniffer-composer-installer": "^0.4.4",
         "escapestudios/symfony2-coding-standard": "^3.0",
         "phpmd/phpmd": "^2.6",
-        "slevomat/coding-standard": "^4.5",
+        "slevomat/coding-standard": "^4.6",
         "squizlabs/php_codesniffer": "^3.0"
     },
     "require-dev": {
diff --git a/composer.lock b/composer.lock
diff --git a/src/LEVIY/ruleset.xml b/src/LEVIY/ruleset.xml
@@ -66,7 +66,7 @@
     the use of native type hints is impossible. -->
     <rule ref="SlevomatCodingStandard.TypeHints.TypeHintDeclaration">
         <properties>
-            <property name="usefulAnnotations" type="array" value="@dataProvider,@Given,@When,@Then"/>
+            <property name="allAnnotationsAreUseful" value="true"/>
         </properties>
     </rule>
 
diff --git a/tests/correct/annotations.php b/tests/correct/annotations.php
@@ -2,8 +2,8 @@
 declare(strict_types=1);
 
 /**
- * @dataProvider
+ * @whatever
  */
-function dataProviderAnnotationsAreAllowed(): void
+function allUsefulAnnotationsAreAllowed(): void
 {
 }

Original file line number	Diff line number	Diff line change
`@@ -2,8 +2,8 @@`
`2`	`2`	`declare(strict_types=1);`
`3`	`3`
`4`	`4`	`/**`
`5`		`- * @dataProvider`
	`5`	`+ * @whatever`
`6`	`6`	`*/`
`7`		`-function dataProviderAnnotationsAreAllowed(): void`
	`7`	`+function allUsefulAnnotationsAreAllowed(): void`
`8`	`8`	`{`
`9`	`9`	`}`