Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enumerize tracepoint categories #314

Closed
danielocfb opened this issue Jan 17, 2023 · 1 comment
Closed

enumerize tracepoint categories #314

danielocfb opened this issue Jan 17, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@danielocfb
Copy link
Collaborator

danielocfb commented Jan 17, 2023 •
edited
Loading

We should consider introducing a proper enum for tracepoint categories. Relying on a textual representation seems...icky.

Edit: See

libbpf-rs/libbpf-rs/src/program.rs

Lines 919 to 920 in 2ce4954

tp_category: impl AsRef<str>,
tp_name: impl AsRef<str>,

@danielocfb danielocfb self-assigned this Jan 17, 2023
@danielocfb danielocfb removed their assignment Mar 17, 2023
@danielocfb danielocfb added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 17, 2023
syogaraj added a commit to syogaraj/libbpf-rs that referenced this issue Mar 6, 2025
@syogaraj
enumerize tracepoint categories libbpf#314
a662c37 
Signed-off-by: yogaraj.s <[email protected]>
syogaraj added a commit to syogaraj/libbpf-rs that referenced this issue Mar 6, 2025
@syogaraj
Enumerize tracepoint categories as described in libbpf#314
7da8608 
Signed-off-by: yogaraj.s <[email protected]>
syogaraj added a commit to syogaraj/libbpf-rs that referenced this issue Mar 6, 2025
@syogaraj
Enumerize tracepoint categories as described in libbpf#314
2ab7e90 
Signed-off-by: yogaraj.s <[email protected]>
syogaraj added a commit to syogaraj/libbpf-rs that referenced this issue Mar 6, 2025
@syogaraj
Enumerize tracepoint categories as described in libbpf#314
faf5c6a 
Signed-off-by: yogaraj.s <[email protected]>
syogaraj added a commit to syogaraj/libbpf-rs that referenced this issue Mar 7, 2025
@syogaraj
Enumerize tracepoint categories as described in libbpf#314
65f95e5 
Signed-off-by: yogaraj.s <[email protected]>
syogaraj added a commit to syogaraj/libbpf-rs that referenced this issue Mar 7, 2025
@syogaraj
Enumerize tracepoint categories as described in libbpf#314
9302957 
Signed-off-by: yogaraj.s <[email protected]>
syogaraj added a commit to syogaraj/libbpf-rs that referenced this issue Mar 7, 2025
@syogaraj
Enumerize tracepoint categories as described in libbpf#314
f63bad8 
Signed-off-by: yogaraj.s <[email protected]>
syogaraj added a commit to syogaraj/libbpf-rs that referenced this issue Mar 8, 2025
@syogaraj
Enumerize tracepoint categories as described in libbpf#314
451cd76 
Signed-off-by: yogaraj.s <[email protected]>
syogaraj added a commit to syogaraj/libbpf-rs that referenced this issue Mar 8, 2025
@syogaraj
Enumerize tracepoint categories as described in libbpf#314
0dfde95 
Signed-off-by: yogaraj.s <[email protected]>
@d-e-s-o
Copy link
Collaborator

d-e-s-o commented Mar 13, 2025

Closed via f772b31

@d-e-s-o d-e-s-o closed this as completed Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@d-e-s-o @danielocfb