Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wss: sni addrs support #5814

Open
guillaumemichel opened this issue Jan 15, 2025 · 0 comments
Open

wss: sni addrs support #5814

guillaumemichel opened this issue Jan 15, 2025 · 0 comments

Comments

@guillaumemichel
Copy link
Contributor

Description

SNI addresses of the format /ip4/192.0.2.0/tcp/1234/tls/sni/foo.example.com/ws don't seem to be supported for websockets in rust-libp2p.

Motivation

autotls is a new service allowing nodes to request a tls certificate matching their peer ID, allowing libp2p nodes to act as wss servers without having to manually configure a certificate tied to a domain name. The default advertised addresses are of the format /ip4/192.0.2.0/tcp/1234/tls/sni/192-0-2-0.<peerid>.libp2p.direct/ws, and rust-libp2p nodes were unable to dial these types of addresses. However, rust-libp2p nodes were able to dial addresses like /dns4/192-0-2-0.<peerid>.libp2p.direct/tcp/1234/tls/ws.

Also libp2p websockets spec specifies that sni addresses should be supported.

Current Implementation

This new address format was added in the specs 3 months ago, hence this may be the reason why it isn't implemented yet.

Related: #5529 (comment)

cc: @oblique I believe this change would benefit Lumina. If autotls is deployed in celestia-node, it means that browser nodes would be able to connect to much more nodes in the Celestia network.

Are you planning to do it yourself in a pull request?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant