Merge pull request #1258 from a-gave/ci_luacheck_shellchek

ci: add linting via luacheck and shellcheck

Author: ilario

.github/workflows/lint.yml

@@ -0,0 +1,31 @@
+name: Lint
+
+on:
+  push:
+  pull_request:
+    types: [opened, synchronize, reopened]
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+jobs:
+  lua:
+    name: Lua
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - name: Install Dependencies
+        run: sudo apt-get -y update && sudo apt-get -y install lua-check
+      - name: Lint Lua code
+        run: ./tools/ci/lint/lua.sh
+
+  sh:
+    name: Shell
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - name: Install Dependencies
+        run: sudo apt-get -y update && sudo apt-get -y install shellcheck 
+      - name: Lint shell code
+        run: ./tools/ci/lint/sh.sh

tools/ci/lint/lua.sh

@@ -0,0 +1,11 @@
+#!/bin/sh
+
+set -e
+
+local="$1"
+if [ "$local" != "" ] && { [ -f "$local" ] || [ -d "$local" ]; }; then
+    luacheck "$local"
+    return
+fi
+
+luacheck packages tests tools

tools/ci/lint/sh.sh

@@ -0,0 +1,47 @@
+#!/bin/sh
+# from https://github.com/freifunk-gluon/gluon/blob/main/scripts/lint-sh.sh
+
+set -e
+
+is_scriptfile() {
+	echo "$1" | grep -q '\.sh$' || head -n1 "$1" | grep -qE '^#!(.*\<bash|/bin/sh)$'
+}
+
+is_initscript() {
+	head -n1 "$1" | grep -qxF '#!/bin/sh /etc/rc.common'
+}
+
+local="$1"
+if [ "$local" != "" ]; then
+    if [ -d "./${local}" ]; then
+        find "./${local}" -type f | while read -r file; do
+            is_scriptfile "$file" || continue
+
+            echo "Checking $file"
+            shellcheck -f gcc "$file"
+        done
+    elif [ -f "./${local}" ]; then
+        echo "Checking $local"
+        shellcheck -f gcc "$local"
+    fi
+    return
+fi
+
+find tools -type f | while read -r file; do
+	is_scriptfile "$file" || continue
+
+	echo "Checking $file"
+	shellcheck -f gcc "$file"
+done
+
+find packages -type f | while read -r file; do
+	if is_scriptfile "$file"; then
+		echo "Checking $file"
+		shellcheck -f gcc -x -s sh -e SC2039,SC3043,SC3037,SC3057 "$file"
+	elif is_initscript "$file"; then
+		echo "Checking $file (initscript)"
+		shellcheck -f gcc -x -s sh -e SC2034,SC2039,SC3043,SC3037,SC3057 "$file"
+	fi
+done
+
+shellcheck -f gcc -x run_tests