Renderer GPU(vulkan/x11): stops rendering after window resize

[Green-Sky]

With the following error log:

ERROR: Failed to acquire swapchain texture:
ERROR: Failed to acquire swapchain texture:
ERROR: Failed to acquire swapchain texture:

The rest of the application continues fine sdl events seem to stop.

on https://github.com/libsdl-org/SDL/releases/tag/preview-3.1.3
9dd8859 still worked fine

edit: this seems to have gradually degraded

• 9dd8859 still worked fine
• sometime after it started to print the ERROR: Failed to acquire swapchain texture: while resizing and look funny, but still keep working after
• afdf325 breaks it totally

edit2: this is on a linux x11 NVIDIA device (555.58.02)

[Green-Sky]

Force quitting hung the whole x11 session for 1sec.

[Green-Sky]

$ git bisect good
afdf325fb4090e93a124519d1a3bc1fbe0ba9025 is the first bad commit
commit afdf325fb4090e93a124519d1a3bc1fbe0ba9025
Author: Evan Hemsley <2342303+thatcosmonaut@users.noreply.github.com>
Date:   Mon Sep 30 10:23:19 2024 -0700

    GPU: Add swapchain dimension out params (#11003)

 include/SDL3/SDL_gpu.h          |  22 ++-
 src/dynapi/SDL_dynapi_procs.h   |   2 +-
 src/gpu/SDL_gpu.c               |  12 +-
 src/gpu/SDL_sysgpu.h            |   4 +-
 src/gpu/d3d11/SDL_gpu_d3d11.c   |  23 ++-
 src/gpu/d3d12/SDL_gpu_d3d12.c   |  26 ++-
 src/gpu/metal/SDL_gpu_metal.m   |  16 +-
 src/gpu/vulkan/SDL_gpu_vulkan.c | 492 +++++++++++++++++++++++------------------------
 src/render/gpu/SDL_render_gpu.c |  19 +-
 test/testgpu_simple_clear.c     |   2 +-
 test/testgpu_spinning_cube.c    |   6 +-
 11 files changed, 343 insertions(+), 281 deletions(-)

#11003

[flibitijibibo]

A few things that'll help us diagnose:

• Is there a specific test app that exhibits this behavior?
• Does this also happen via Xwayland?
• Do the Vulkan validation layers point to anything in particular? The SDL examples should enable them in debug mode, provided the system has them installed.

[Green-Sky]

A few things that'll help us diagnose:

• Is there a specific test app that exhibits this behavior?

The test/testgpu_spinning_cube simply exits as soon as first

Failed to acquire swapchain texture:

is encountered.
I checked and be401dd introduced this behavoir. This seems to be intended, but I am not sure it actually is an error that is reported.

The test/testnative executable however exhibits my issue perfectly. Just resize it until it hangs the screen or stops rendering (but keep running).

sdl3_renderer_gpu_vulkan_error1.mp4

(includes a lack of frames at the x11(?) freeze)

• Does this also happen via Xwayland?
• Do the Vulkan validation layers point to anything in particular? The SDL examples should enable them in debug mode, provided the system has them installed.

Not sure how to enable the validation layers, but I will keep trying.
On my x11-nvidia nixos setup I am not comfortable switching to wayland yet, however that is on my longterm todo list :)

[thatcosmonaut]

Curious if this is possibly related to #9698

[meyraud705]

On an AMD card on X11 I get errors and sometimes a validation layer message when resizing, then application continues fine:

ERROR: vkQueuePresentKHR VK_SUBOPTIMAL_KHR
ERROR: vkQueuePresentKHR VK_SUBOPTIMAL_KHR
ERROR: vkQueuePresentKHR VK_SUBOPTIMAL_KHR
VUID-VkSwapchainCreateInfoKHR-pNext-07781(ERROR / SPEC): msgNum: 1284057537 - Validation Error: [ VUID-VkSwapchainCreateInfoKHR-pNext-07781 ] | MessageID = 0x4c8929c1 | vkCreateSwapchainKHR(): pCreateInfo->imageExtent (width = 545, height = 462), which is outside the bounds returned by vkGetPhysicalDeviceSurfaceCapabilitiesKHR(): currentExtent = (width = 553, height = 468), minImageExtent = (width = 553, height = 468), maxImageExtent = (width = 553, height = 468). The Vulkan spec states: If a VkSwapchainPresentScalingCreateInfoEXT structure was not included in the pNext chain, or it is included and VkSwapchainPresentScalingCreateInfoEXT::scalingBehavior is zero then imageExtent must be between minImageExtent and maxImageExtent, inclusive, where minImageExtent and maxImageExtent are members of the VkSurfaceCapabilitiesKHR structure returned by vkGetPhysicalDeviceSurfaceCapabilitiesKHR for the surface (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-VkSwapchainCreateInfoKHR-pNext-07781)
    Objects: 0
ERROR: vkQueuePresentKHR VK_SUBOPTIMAL_KHR
ERROR: vkQueuePresentKHR VK_SUBOPTIMAL_KHR

[flibitijibibo]

I think we ended up removing the extent checks because we thought the window events covered it, but it seems X11 has other ideas - I think all we need to revert from the bad commits is the removal of min/max size checks and this will work again.

[thatcosmonaut]

This may have been fixed by 6ae5666. Someone who can repro will have to confirm.

[Green-Sky]

@thatcosmonaut I did check yesterday, but no change.

[thatcosmonaut]

@Green-Sky Could you try testing this PR: #11139

[Green-Sky]

@thatcosmonaut the pr does not change the behavior.

[KitsuneAlex]

@thatcosmonaut the pr does not change the behavior.

Can confirm, issue is persisting for me on PopOS 22.04/Kernel 6.9.3-76060903-generic/X11/NVIDIA 560.35.03