Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] full screen controller test from sdl #11994

Closed
ikhoeyZX opened this issue Jan 16, 2025 · 14 comments
Closed

[question] full screen controller test from sdl #11994

ikhoeyZX opened this issue Jan 16, 2025 · 14 comments
Assignees
Milestone

Comments

@ikhoeyZX
Copy link

sdl controller tester was great
but some menu didn't appear because not fullscreen

Screenshot_20250116_172344_testcontroller

how i can make this fullscreen?
tried change theme styles (in androidmanifest) but didn't work

@slouken
Copy link
Collaborator

slouken commented Jan 16, 2025

  • What device are you using?
  • What version of Android are you running?
  • What version of SDL are you using?

@slouken slouken added this to the 3.2.0 milestone Jan 16, 2025
@slouken slouken self-assigned this Jan 16, 2025
@ikhoeyZX
Copy link
Author

ikhoeyZX commented Jan 16, 2025

  • What device are you using?

samsung m33 5g

* What version of Android are you running?

android 14

* What version of SDL are you using?

sdl 3.2

@slouken
Copy link
Collaborator

slouken commented Jan 20, 2025

I'm not sure what's happening there. This is what it looks like on my Samsung S24 running Android 14:

Image

@slouken slouken modified the milestones: 3.2.0, 3.x Jan 20, 2025
@ikhoeyZX
Copy link
Author

hmm
that's weird
i did test from this build [ https://github.com/libsdl-org/SDL/commit/8526868563eddbd9df99530c4625fe0fb1d6b07c ] and still same

Image

@AntTheAlchemist
Copy link
Contributor

It kinda looks like it is full screen (letterboxed), as it should, if it weren't for that "SDL Controller Test" title, which is overlaying the top of the surface. Could it be an issue with the theme config?

@ikhoeyZX
Copy link
Author

looks like it

and this one from android 9 phone (redmi a1) using same version of sdl apk

Image

@slouken
Copy link
Collaborator

slouken commented Jan 21, 2025

Hmm, what happens if you use the APK I built?
https://www.libsdl.org/tmp/testcontroller.apk

@ikhoeyZX
Copy link
Author

Hmm, what happens if you use the APK I built? https://www.libsdl.org/tmp/testcontroller.apk

this one work's fine in my phone
Image

@slouken
Copy link
Collaborator

slouken commented Jan 21, 2025

Great! I just built it using the normal process from the android-project included with SDL.

@AntTheAlchemist
Copy link
Contributor

This is what's in my res/values/styles.xml. I played with a few options and this one works best for me. android-project uses android:Theme.NoTitleBar.Fullscreen, but I'm unsure what the exact difference is. This must be what's causing that ugly title bar at the top in your project @ikhoeyZX ?

<resources>
    <style name="AppTheme" parent="android:Theme.Material.NoActionBar.Fullscreen">
    </style>
</resources>

@ikhoeyZX
Copy link
Author

i did put it in android-project/app/src/main/AndroidManifest.xml

        android:theme="@android:style/Theme.NoTitleBar.Fullscreen"

and that didn't work
maybe i need put it in style.xml instead inside androidmanifest.xml

@madebr
Copy link
Contributor

madebr commented Jan 21, 2025

I could fix it locally by adding a theme:
efa6e7a

Please try the apk artifacts at the bottom of this GitHub job:
https://github.com/libsdl-org/SDL/actions/runs/12894279562

@ikhoeyZX
Copy link
Author

I could fix it locally by adding a theme: efa6e7a

Please try the apk artifacts at the bottom of this GitHub job: https://github.com/libsdl-org/SDL/actions/runs/12894279562

thanks, it worked
Image

@slouken
Copy link
Collaborator

slouken commented Jan 22, 2025

Great!

@slouken slouken closed this as completed Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants