Split LiftSession into multiple source files

[farmdawgnation]

The LiftSession source is current 3,281 lines long. Notably the LiftSession implementation alone is > 2k lines, so this is probably something we could split up into different traits to make it a bit easier to grok.

[fmpwizard]

may be worth bringing it up on the list but how would having liftsession objects/traits split into several file be easier than all in one place where I can just scroll up/down ?

[farmdawgnation]

may be worth bringing it up on the list but how would having liftsession objects/traits split into several file be easier than all in one place where I can just scroll up/down ?

I find trying to navigate large files a lot more frustrating than you do apparently. Hehe. I am most effective at coding when I can keep oriented at where I am in the file and past a few thousand lines I begin to be unable to do that.

But on a practical level, I do think that LiftSession has a lot of different concerns all rolled into one right now. And there are a lot of oddball things in the file that aren't even directly related to a LiftSession (e.g. a type of Actor that knows about session). I think in the process of doing this we'll find areas where different concerns are tightly coupled or sharing state where they maybe shouldn't be. We'll also make it easier on folks who are just exploring the codebase file-by-file by reducing the number of behemoth files we have to a minimum number.

If you think there are issues here, we can kick off a thread.

[fmpwizard]

Ok, let's go with splitting it, assuming you won't go crazy with the refactor :)