Skip to content

Commit a06e7b9

Browse files
committed
Check workspace members with default features individually in CI
Previously, we would only check the workspace as a whole. This however would mean that we would check/test crates with `lightning`'s default features enabled, allowing failures-to-build under the crates own default features to slip through, if they didn't explicitly enable `lightning/std`, for example. Here, we extend the CI to check the workspace as a whole but then run checks, tests, and doc generation on the workspace members individually, asserting that all of them build even when not built as part of the same workspace as `lightning`.
1 parent 3c1a5d3 commit a06e7b9

File tree

1 file changed

+23
-3
lines changed

1 file changed

+23
-3
lines changed

ci/ci-tests.sh

+23-3
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,31 @@ PIN_RELEASE_DEPS # pin the release dependencies in our main workspace
3030

3131
export RUST_BACKTRACE=1
3232

33-
echo -e "\n\nBuilding and testing all workspace crates..."
34-
cargo test --verbose --color always
33+
echo -e "\n\nChecking the full workspace."
3534
cargo check --verbose --color always
3635

37-
echo -e "\n\nBuilding and testing Block Sync Clients with features"
36+
WORKSPACE_MEMBERS=(
37+
lightning
38+
lightning-types
39+
lightning-block-sync
40+
lightning-invoice
41+
lightning-net-tokio
42+
lightning-persister
43+
lightning-background-processor
44+
lightning-rapid-gossip-sync
45+
lightning-custom-message
46+
lightning-transaction-sync
47+
possiblyrandom
48+
)
49+
50+
echo -e "\n\nChecking, testing, and building docs for all workspace members individually..."
51+
for DIR in "${WORKSPACE_MEMBERS[@]}"; do
52+
cargo test -p "$DIR" --verbose --color always
53+
cargo check -p "$DIR" --verbose --color always
54+
cargo doc -p "$DIR" --document-private-items
55+
done
56+
57+
echo -e "\n\nChecking and testing Block Sync Clients with features"
3858

3959
cargo test -p lightning-block-sync --verbose --color always --features rest-client
4060
cargo check -p lightning-block-sync --verbose --color always --features rest-client

0 commit comments

Comments
 (0)