Merge pull request #4028 from jkczyz/2025-08-splice-out-fixups

Follow-ups for #3979

Author: jkczyz

lightning/src/ln/channel.rs

@@ -11134,7 +11134,7 @@ where
 		};
 
 		let our_funding_contribution = funding_negotiation_context.our_funding_contribution;
-		debug_assert!(our_funding_contribution <= SignedAmount::MAX_MONEY);
+		debug_assert!(our_funding_contribution.abs() <= SignedAmount::MAX_MONEY);
 
 		let their_funding_contribution = SignedAmount::from_sat(msg.funding_contribution_satoshis);
 		self.validate_splice_contribution(their_funding_contribution)?;

lightning/src/ln/funding.rs

@@ -24,8 +24,8 @@ pub enum SpliceContribution {
 		/// The amount to contribute to the splice.
 		value: Amount,
 
-		/// The inputs included in the splice's funding transaction to meet the contributed amount.
-		/// Any excess amount will be sent to a change output.
+		/// The inputs included in the splice's funding transaction to meet the contributed amount
+		/// plus fees. Any excess amount will be sent to a change output.
 		inputs: Vec<FundingTxInput>,
 
 		/// An optional change output script. This will be used if needed or, when not set,
@@ -35,7 +35,7 @@ pub enum SpliceContribution {
 	/// When funds are removed from a channel.
 	SpliceOut {
 		/// The outputs to include in the splice's funding transaction. The total value of all
-		/// outputs will be the amount that is removed.
+		/// outputs plus fees will be the amount that is removed.
 		outputs: Vec<TxOut>,
 	},
 }