Skip to content

Commit fa33f98

Browse files
committed
Fix overflow in awaiting_pong_timer... with too many peers
If we have more than 127 / `MAX_BUFFER_DRAIN_TICK_INTERVALS_PER_PEER` (31) peers, `awaiting_pong_timer_tick_intervals` can overflow before we hit the limit. This isn't super harmful, we'll still disconnect peers as long as they don't send *any* messages between two pings, but it does cause us to not disconnect peers which are extremely slow in responding to messages, e.g. because they are overloaded.
1 parent 88c63e9 commit fa33f98

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lightning/src/ln/peer_handler.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ struct Peer {
416416
sync_status: InitSyncTracker,
417417

418418
msgs_sent_since_pong: usize,
419-
awaiting_pong_timer_tick_intervals: i8,
419+
awaiting_pong_timer_tick_intervals: i64,
420420
received_message_since_timer_tick: bool,
421421
sent_gossip_timestamp_filter: bool,
422422

0 commit comments

Comments
 (0)