Should render without 3rd party assets

[mryellow]

Coming Soon?

Without jQuery.com unblocked the page fails to display and instead renders alternate content which suggests the site has completely loaded, but lacks actual listings.

No indication is given that further assets are required or that the page has not finished loading as intended.

[mryellow]

lightningnetworkstores.github.io/js/main.js

Lines 20 to 41 in eeb2e53

	for(var i in data){
	var d = data[i];
	var inject =
	'<div class="panel">' +
	'<h3> <a href="'+d.href+'">'+d.name+'</a></h3>' +
	'<p class="text-muted">'+d.description+'</p>' +
	'<p><strong>URI:</strong> '+d.uri+'</p>' +
	'</div>' +
	'<hr>';
	if(d.flags){
	if(d.flags['hidden'] == 1)
	continue;
	if(d.flags['coming_soon'] == 1)
	soon.append(inject);
	continue;
	}
	main.append(inject);
	}

Actually Javascript isn't required at all here, seems to be used to avoid any "server-side" code for gh-pages.

Here's a similar loop through JSON data being templated with nunjucks. Built offline from local JSON then committed to the docs directory for gh-pages to pickup.

https://github.com/mryellow/ethercraft_farm_ui/blob/f11f2a3b2896b418d6f51cd124e9aecd76628f54/src/index.html#L345-L358

Here the JSON is fed to Nunjucks by Gulp:

https://github.com/mryellow/ethercraft_farm_ui/blob/f11f2a3b2896b418d6f51cd124e9aecd76628f54/gulp-tasks/build/html.js#L12-L17

edit: More info on the gulp tasks for that boilerplate https://github.com/mryellow/gulp-nunjucks-boilerplate (without the extra contracts.json stuff)

[lightningnetworkstores]

I moved jquery-3.3.1.min.js to a local folder. Regarding the loop through JSON, feel free to make a pull request, I don't mind if the code is not super optimized... As long as the page loads successfully and quickly on all devices and browsers I am ok with it.