Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In release mode, switch from page_allocator to c_allocator #426

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

karlseguin
Copy link
Contributor

I'm not sure if the page_allocator was chosen for a specific reason, but I've always heard that the GPA should be used in debug/test, and the c_allocator in release.

@krichprollsch
Copy link
Member

I suppose we used the page allocator b/c Zig's doc recommends it with arena.
https://ziglang.org/documentation/master/#toc-Choosing-an-Allocator

But indeed using c_allocator is a better option since we link with libc.

before I merge it, @karlseguin can you rebase the branch to run the end-to-end regression tests please?

@karlseguin
Copy link
Contributor Author

I suppose we used the page allocator b/c Zig's doc recommends it with arena. https://ziglang.org/documentation/master/#toc-Choosing-an-Allocator

But indeed using c_allocator is a better option since we link with libc.

before I merge it, @karlseguin can you rebase the branch to run the end-to-end regression tests please?

done

@krichprollsch
Copy link
Member

Thanks! 👍

@krichprollsch krichprollsch merged commit fcdcb50 into lightpanda-io:main Feb 20, 2025
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
@karlseguin karlseguin deleted the c_allocator branch February 20, 2025 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants