From 6aba36eb1a21e6f9b8f4749031c54904f1c15c97 Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Wed, 10 Apr 2024 10:14:26 +0200 Subject: [PATCH 1/2] bench: move jsruntime bench in its own subdir --- cmd/history/main.go | 7 ++----- main.go | 2 +- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/cmd/history/main.go b/cmd/history/main.go index 5525e58..e1f29c3 100644 --- a/cmd/history/main.go +++ b/cmd/history/main.go @@ -39,9 +39,6 @@ func main() { } const ( - SourceBench = "bench" - SourceWPT = "wpt" - AWSRegion = "eu-west-3" AWSBucket = "lpd-perf" ) @@ -99,7 +96,7 @@ func run(ctx context.Context, args []string, stdout, stderr io.Writer) error { } // pull history.json file - fio, err := s3.NewS3IO(env("AWS_BUCKET", AWSBucket), "bench/history.json") + fio, err := s3.NewS3IO(env("AWS_BUCKET", AWSBucket), "bench/jsruntime/history.json") if err != nil { return fmt.Errorf("news3io single result: %w", err) } @@ -162,7 +159,7 @@ APPEND: // upload all individual file to s3 filename := fmt.Sprintf("%s_%v.json", v.Time.Format("2006-01-02_15-04"), v.Hash) - fio, err := s3.NewS3IO(env("AWS_BUCKET", AWSBucket), "bench/"+filename) + fio, err := s3.NewS3IO(env("AWS_BUCKET", AWSBucket), "bench/jsruntime/"+filename) if err != nil { return fmt.Errorf("news3io single result: %w", err) } diff --git a/main.go b/main.go index 85392a2..f35bf7e 100644 --- a/main.go +++ b/main.go @@ -49,7 +49,7 @@ const ( AWSRegion = "eu-west-3" AWSBucket = "lpd-perf" - PathBenchJSRuntime = "bench" + PathBenchJSRuntime = "bench/jsruntime" PathBenchBrowser = "bench/browser" PathWPT = "wpt" ) From 022c338e4266c77ddec4a13916ab10abab336ea6 Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Wed, 10 Apr 2024 10:16:59 +0200 Subject: [PATCH 2/2] remvoe deprecated bench argument --- main.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/main.go b/main.go index f35bf7e..c8f7298 100644 --- a/main.go +++ b/main.go @@ -43,9 +43,6 @@ const ( SourceBenchBrowser = "bench-browser" SourceWPT = "wpt" - // deprecated source, alias to bench-jsruntime. - SourceBench = "bench" - AWSRegion = "eu-west-3" AWSBucket = "lpd-perf" @@ -94,7 +91,7 @@ func run(ctx context.Context, args []string, stdout, stderr io.Writer) error { ) switch args[0] { - case SourceBench, SourceBenchJSRuntime: + case SourceBenchJSRuntime: append = &jsrbench.Append{} path = PathBenchJSRuntime case SourceBenchBrowser: