Make MacroPy3 compatible with Python 3.11 #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made changes to comply with the following runtime changes. In Python 3.8+, lineno/col_offset became required, as part of the adoption of the peg_parser. In Python 3.8+, arguments has a new parameter - posonlyargs. The value of Subscript.slice was changed from Index to expr in Python 3.9 as part of the "Parental Scope References in Named Expressions" proposal (PEP 572).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made changes to comply with the following runtime changes.
In Python 3.8+, lineno/col_offset became required, as part of the adoption of the peg_parser.
In Python 3.8+, arguments has a new parameter - posonlyargs.
The value of Subscript.slice was changed from Index to expr in Python 3.9 as part of the "Parental Scope References in Named Expressions" proposal (PEP 572).
With these changes tests don't actually pass, but they do fail, which is an improvement. Before, we couldn't even run the tests. I'm not sure to what degree these failures are the results of real problems vs just needing to fix up the tests in response to runtime changes.