Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QEMU: Support feature toggle for GA via serial port #3177

Open
arixmkii opened this issue Jan 30, 2025 · 2 comments · May be fixed by #3255
Open

QEMU: Support feature toggle for GA via serial port #3177

arixmkii opened this issue Jan 30, 2025 · 2 comments · May be fixed by #3255

Comments

@arixmkii
Copy link
Contributor

Description

Follow up to #3148 (comment) Serial port mode was quick disabled by commenting out one line due to some instabilities, but other parts related kept untouched. First of all both parts should honor the same mode and as the supporting code is already there it could be extended to have feature toggle, so, the mode could be re-enabled if desired. This would also be vital for Windows hosts until Unix socket forwarding is figured out.

I plan to work on this - continuing and repurposing my draft PR #3148

@nirs
Copy link
Member

nirs commented Jan 30, 2025

The description #3184 could be useful here. It is hard to understand the problem from this issue description.

It is also important to understand if we really need to toggle this, and how do you plan to toggle it? A new lima.yaml configuration? extending existing configuration?

@arixmkii
Copy link
Contributor Author

I was considering per machine setting inside lima.yaml in the QEMU related section, but I haven't checked the actual code yet and can't comment on a final decision yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants