Commit 2d13d9f
fix: handle nat66 prefix and unsupported opts in --vmnet-disable-dhcp
Follow-up to Copilot review on the macOS 26 --vmnet-disable-dhcp path:
- Apply --vmnet-nat66-prefix via vmnet_network_configuration_set_ipv6_prefix
(parsed with inet_pton, /64), mirroring the legacy vmnet_nat66_prefix_key.
- Warn that --vmnet-interface-id and --vmnet-network-identifier are ignored
on this path: the macOS 26 vmnet network configuration API has no setter
for the network identifier, and vmnet_interface_start_with_network assigns
its own interface id (verified empirically on macOS 26.4).
- Validate --vmnet-gateway / --vmnet-mask separately and print the offending
value instead of relying on errno (inet_aton does not set errno on failure).
- Tighten the disable-dhcp test assertion and PID handling.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent f5035c7 commit 2d13d9f
2 files changed
Lines changed: 13 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
271 | 271 | | |
272 | 272 | | |
273 | 273 | | |
274 | | - | |
275 | | - | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
276 | 280 | | |
277 | 281 | | |
278 | 282 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
19 | 21 | | |
20 | | - | |
21 | 22 | | |
22 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
23 | 27 | | |
24 | 28 | | |
25 | 29 | | |
| |||
0 commit comments