Commit 8319b05
committed
feat(evaluation): the EvalRunner Ray actor and its dispatcher
`EvalRunner` executes one run: upload and time each corpus file, shell out
to promptfoo twice, fold the outputs into metrics, persist, drop the
throwaway partition. `RayEvaluationRunner` binds it to the
`EvaluationRunner` port and keeps every Ray concern — actor lookup,
`.remote()`, timeouts, cancellation — on the worker side of the boundary.
The runner drives OpenRAG through its own HTTP API rather than in-process
calls, for two reasons: it is the path a real user's documents take, so the
indexing timings mean something, and it is the same surface promptfoo
talks to, so an eval can never pass against a code path the API does not
expose.
Notes:
- The actor handle is resolved on first use, not in `__init__`. `EvalRunner`
is detached, so merely building the adapter must not be what spawns it —
listing datasets should not start a worker process.
- `run()` never raises. The caller dispatched it fire-and-forget and has
nobody to catch for, so every outcome is written to the run row.
- One bad corpus file is recorded as a failed sample rather than voiding
the run; every file failing is an error worth surfacing.
- promptfoo exits non-zero when assertions fail, which is a result, not an
error — the presence of the output file is what decides. Both streams are
captured, since promptfoo reports config errors on stdout.
- Each run gets its own `PROMPTFOO_CONFIG_DIR`. promptfoo keeps a SQLite
history under it, defaulting to `$HOME/.promptfoo`, which is not
guaranteed writable in a container.
- `max_concurrency=4` so `cancel()` and `is_busy()` still land while
`run()` holds a slot.1 parent f15c899 commit 8319b05
5 files changed
Lines changed: 479 additions & 0 deletions
File tree
- openrag
- di
- services/workers
- tests/unit/di
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
| 63 | + | |
63 | 64 | | |
64 | 65 | | |
65 | 66 | | |
| |||
117 | 118 | | |
118 | 119 | | |
119 | 120 | | |
| 121 | + | |
120 | 122 | | |
121 | 123 | | |
122 | 124 | | |
| |||
464 | 466 | | |
465 | 467 | | |
466 | 468 | | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
467 | 488 | | |
468 | 489 | | |
469 | 490 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
152 | 157 | | |
153 | 158 | | |
154 | 159 | | |
| |||
159 | 164 | | |
160 | 165 | | |
161 | 166 | | |
| 167 | + | |
162 | 168 | | |
163 | 169 | | |
164 | 170 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
0 commit comments