Skip to content

Commit 4f0b58d

Browse files
mikebeatonnate-desimone
authored andcommitted
Features/Intel|Platforms/Intel: Complete pending changes to [Components.{ARCH}]
As noted in the code, it was intended to update various manually specified instances of [Components.IA32/X64] to [Components.$(DXE_ARCH)] or [Components.$(PEI_ARCH)] as appropriate, once macro expansion in the Components {ARCH} value was supported. This support was added some time ago[1], but the marked changes were never made. [1]: https://bugzilla.tianocore.org/show_bug.cgi?id=2308 Signed-off-by: Mike Beaton <[email protected]>
1 parent 6dd1f33 commit 4f0b58d

File tree

18 files changed

+41
-140
lines changed

18 files changed

+41
-140
lines changed

Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc

+1-4
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,7 @@
4242
#
4343
# Feature DXE Components
4444
#
45-
46-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
47-
# is completed.
48-
[Components.X64]
45+
[Components.$(DXE_ARCH)]
4946
#####################################
5047
# ACPI Debug Feature Package
5148
#####################################

Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc

+1-4
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,7 @@
6363
#
6464
# Feature DXE Components
6565
#
66-
67-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
68-
# is completed.
69-
[Components.X64]
66+
[Components.$(DXE_ARCH)]
7067
#####################################
7168
# Network Feature Package
7269
#####################################

Features/Intel/OutOfBandManagement/AsfFeaturePkg/Include/AsfFeature.dsc

+2-8
Original file line numberDiff line numberDiff line change
@@ -36,17 +36,11 @@
3636
#
3737
# Feature PEI Components
3838
#
39-
40-
# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
41-
# is completed.
42-
[Components.IA32]
39+
[Components.$(PEI_ARCH)]
4340
AsfFeaturePkg/AsfPei/AsfPei.inf
4441

4542
#
4643
# Feature DXE Components
4744
#
48-
49-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
50-
# is completed.
51-
[Components.X64]
45+
[Components.$(DXE_ARCH)]
5246
AsfFeaturePkg/AsfDxe/AsfDxe.inf

Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc

+2-8
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,7 @@
8282
#
8383
# Feature PEI Components
8484
#
85-
86-
# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
87-
# is completed.
88-
[Components.IA32]
85+
[Components.$(PEI_ARCH)]
8986
#####################################
9087
# IPMI Feature Package
9188
#####################################
@@ -106,10 +103,7 @@
106103
#
107104
# Feature DXE Components
108105
#
109-
110-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
111-
# is completed.
112-
[Components.X64]
106+
[Components.$(DXE_ARCH)]
113107
#####################################
114108
# IPMI Feature Package
115109
#####################################

Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc

+1-4
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,5 @@
4242
# generated for it, but the binary will not be put into any firmware volume.
4343
#
4444
################################################################################
45-
46-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
47-
# is completed.
48-
[Components.X64]
45+
[Components.$(DXE_ARCH)]
4946
SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpiDxe.inf

Features/Intel/PlatformPayloadFeaturePkg/Include/PlatformPayloadFeature.dsc

+1-4
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,7 @@
7171
#
7272
# Feature DXE Components
7373
#
74-
75-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
76-
# is completed.
77-
[Components.X64]
74+
[Components.$(DXE_ARCH)]
7875
#
7976
# SMM Variable Support
8077
#

Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc

+2-8
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,7 @@
6363
#
6464
# Feature PEI Components
6565
#
66-
67-
# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
68-
# is completed.
69-
[Components.IA32]
66+
[Components.$(PEI_ARCH)]
7067
#####################################
7168
# S3 Feature Package
7269
#####################################
@@ -79,10 +76,7 @@
7976
#
8077
# Feature DXE Components
8178
#
82-
83-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
84-
# is completed.
85-
[Components.X64]
79+
[Components.$(DXE_ARCH)]
8680
#####################################
8781
# S3 Feature Package
8882
#####################################

Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeature.dsc

+1-4
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,7 @@
5151
#
5252
# Feature DXE Components
5353
#
54-
55-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
56-
# is completed.
57-
[Components.X64]
54+
[Components.$(DXE_ARCH)]
5855
#####################################
5956
# SMBIOS Feature Package
6057
#####################################

Features/Intel/TemplateFeaturePkg/Include/TemplateFeature.dsc

+2-8
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,7 @@
6868
#
6969
# Feature PEI Components
7070
#
71-
72-
# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
73-
# is completed.
74-
[Components.IA32]
71+
[Components.$(PEI_ARCH)]
7572
#####################################
7673
# <TEMPLATE> Feature Package
7774
#####################################
@@ -84,10 +81,7 @@
8481
#
8582
# Feature DXE Components
8683
#
87-
88-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
89-
# is completed.
90-
[Components.X64]
84+
[Components.$(DXE_ARCH)]
9185
#####################################
9286
# <TEMPLATE> Feature Package
9387
#####################################

Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc

+1-4
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,7 @@
4343
#
4444
# Feature DXE Components
4545
#
46-
47-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
48-
# is completed.
49-
[Components.X64]
46+
[Components.$(DXE_ARCH)]
5047
!if gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable == TRUE
5148
LogoFeaturePkg/LogoDxe/JpegLogoDxe.inf
5249
!else

Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.dsc

+1-4
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,7 @@
5959
#
6060
# Feature DXE Components
6161
#
62-
63-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
64-
# is completed.
65-
[Components.X64]
62+
[Components.$(DXE_ARCH)]
6663
#####################################
6764
# User Authentication Feature Package
6865
#####################################

Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc

+4-12
Original file line numberDiff line numberDiff line change
@@ -72,15 +72,11 @@
7272
#######################################
7373
# Component Includes
7474
#######################################
75-
# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
76-
# is completed
77-
[Components.IA32]
75+
[Components.$(PEI_ARCH)]
7876
!include $(PLATFORM_PACKAGE)/Include/Dsc/CorePeiInclude.dsc
7977
!include $(PLATFORM_SI_PACKAGE)/SiPkgPei.dsc
8078

81-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
82-
# is completed
83-
[Components.X64]
79+
[Components.$(DXE_ARCH)]
8480
!include $(PLATFORM_PACKAGE)/Include/Dsc/CoreDxeInclude.dsc
8581
!include $(PLATFORM_SI_PACKAGE)/SiPkgDxe.dsc
8682

@@ -269,9 +265,7 @@
269265
#######################################
270266
# PEI Components
271267
#######################################
272-
# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
273-
# is completed
274-
[Components.IA32]
268+
[Components.$(PEI_ARCH)]
275269
#######################################
276270
# Edk2 Packages
277271
#######################################
@@ -345,9 +339,7 @@
345339
#######################################
346340
# DXE Components
347341
#######################################
348-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
349-
# is completed
350-
[Components.X64]
342+
[Components.$(DXE_ARCH)]
351343
#######################################
352344
# Edk2 Packages
353345
#######################################

Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg.dsc

+4-13
Original file line numberDiff line numberDiff line change
@@ -110,16 +110,11 @@
110110
#######################################
111111
# Component Includes
112112
#######################################
113-
114-
# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
115-
# is completed
116-
[Components.IA32]
113+
[Components.$(PEI_ARCH)]
117114
!include $(PLATFORM_PACKAGE)/Include/Dsc/CorePeiInclude.dsc
118115
!include $(PLATFORM_SI_PACKAGE)/SiPkgPei.dsc
119116

120-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
121-
# is completed
122-
[Components.X64]
117+
[Components.$(DXE_ARCH)]
123118
!include $(PLATFORM_PACKAGE)/Include/Dsc/CoreDxeInclude.dsc
124119
!include $(PLATFORM_SI_PACKAGE)/SiPkgDxe.dsc
125120

@@ -371,9 +366,7 @@
371366
#######################################
372367
# PEI Components
373368
#######################################
374-
# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
375-
# is completed
376-
[Components.IA32]
369+
[Components.$(PEI_ARCH)]
377370
#######################################
378371
# Edk2 Packages
379372
#######################################
@@ -508,9 +501,7 @@
508501
#######################################
509502
# DXE Components
510503
#######################################
511-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
512-
# is completed
513-
[Components.X64]
504+
[Components.$(DXE_ARCH)]
514505
# Compiled .efi but not in FV:
515506
# - dpDynamicCommand, TestPointDumpApp
516507
# Other apps; perhaps useful:

Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc

+4-12
Original file line numberDiff line numberDiff line change
@@ -71,15 +71,11 @@
7171
#######################################
7272
# Component Includes
7373
#######################################
74-
# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
75-
# is completed
76-
[Components.IA32]
74+
[Components.$(PEI_ARCH)]
7775
!include $(PLATFORM_PACKAGE)/Include/Dsc/CorePeiInclude.dsc
7876
!include $(PLATFORM_SI_PACKAGE)/SiPkgPei.dsc
7977

80-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
81-
# is completed
82-
[Components.X64]
78+
[Components.$(DXE_ARCH)]
8379
!include $(PLATFORM_PACKAGE)/Include/Dsc/CoreDxeInclude.dsc
8480
!include $(PLATFORM_SI_PACKAGE)/SiPkgDxe.dsc
8581

@@ -285,9 +281,7 @@
285281
#######################################
286282
# PEI Components
287283
#######################################
288-
# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
289-
# is completed
290-
[Components.IA32]
284+
[Components.$(PEI_ARCH)]
291285
#######################################
292286
# Edk2 Packages
293287
#######################################
@@ -367,9 +361,7 @@
367361
#######################################
368362
# DXE Components
369363
#######################################
370-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
371-
# is completed
372-
[Components.X64]
364+
[Components.$(DXE_ARCH)]
373365
#######################################
374366
# Edk2 Packages
375367
#######################################

Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc

+4-13
Original file line numberDiff line numberDiff line change
@@ -101,16 +101,11 @@
101101
#######################################
102102
# Component Includes
103103
#######################################
104-
105-
# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
106-
# is completed
107-
[Components.IA32]
104+
[Components.$(PEI_ARCH)]
108105
!include $(PLATFORM_PACKAGE)/Include/Dsc/CorePeiInclude.dsc
109106
!include $(PLATFORM_SI_PACKAGE)/SiPkgPei.dsc
110107

111-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
112-
# is completed
113-
[Components.X64]
108+
[Components.$(DXE_ARCH)]
114109
!include $(PLATFORM_PACKAGE)/Include/Dsc/CoreDxeInclude.dsc
115110
!include $(PLATFORM_SI_PACKAGE)/SiPkgDxe.dsc
116111

@@ -292,9 +287,7 @@
292287
#######################################
293288
# PEI Components
294289
#######################################
295-
# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
296-
# is completed
297-
[Components.IA32]
290+
[Components.$(PEI_ARCH)]
298291
#######################################
299292
# Edk2 Packages
300293
#######################################
@@ -407,9 +400,7 @@
407400
#######################################
408401
# DXE Components
409402
#######################################
410-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
411-
# is completed
412-
[Components.X64]
403+
[Components.$(DXE_ARCH)]
413404
#######################################
414405
# Edk2 Packages
415406
#######################################

Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc

+2-6
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,7 @@
7676
!include $(PLATFORM_PACKAGE)/Include/Dsc/CorePeiInclude.dsc
7777
!include $(SKT_PKG)/SktPkgPei.dsc
7878

79-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
80-
# is completed
81-
[Components.X64]
79+
[Components.$(DXE_ARCH)]
8280
!include $(PLATFORM_PACKAGE)/Include/Dsc/CoreDxeInclude.dsc
8381

8482
#######################################
@@ -221,9 +219,7 @@
221219
#######################################
222220
# DXE Components
223221
#######################################
224-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
225-
# is completed
226-
[Components.X64]
222+
[Components.$(DXE_ARCH)]
227223
#######################################
228224
# Edk2 Packages
229225
#######################################

Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc

+4-12
Original file line numberDiff line numberDiff line change
@@ -72,15 +72,11 @@
7272
#######################################
7373
# Component Includes
7474
#######################################
75-
# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
76-
# is completed
77-
[Components.IA32]
75+
[Components.$(PEI_ARCH)]
7876
!include $(PLATFORM_PACKAGE)/Include/Dsc/CorePeiInclude.dsc
7977
!include $(PLATFORM_SI_PACKAGE)/SiPkgPei.dsc
8078

81-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
82-
# is completed
83-
[Components.X64]
79+
[Components.$(DXE_ARCH)]
8480
!include $(PLATFORM_PACKAGE)/Include/Dsc/CoreDxeInclude.dsc
8581
!include $(PLATFORM_SI_PACKAGE)/SiPkgDxe.dsc
8682

@@ -269,9 +265,7 @@
269265
#######################################
270266
# PEI Components
271267
#######################################
272-
# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
273-
# is completed
274-
[Components.IA32]
268+
[Components.$(PEI_ARCH)]
275269
#######################################
276270
# Edk2 Packages
277271
#######################################
@@ -337,9 +331,7 @@
337331
#######################################
338332
# DXE Components
339333
#######################################
340-
# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308
341-
# is completed
342-
[Components.X64]
334+
[Components.$(DXE_ARCH)]
343335
#######################################
344336
# Edk2 Packages
345337
#######################################

0 commit comments

Comments
 (0)