Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a maxOutput prop? #1017

Open
BjornTheProgrammer opened this issue Aug 26, 2022 · 1 comment
Open

Make a maxOutput prop? #1017

BjornTheProgrammer opened this issue Aug 26, 2022 · 1 comment

Comments

@BjornTheProgrammer
Copy link

BjornTheProgrammer commented Aug 26, 2022

I love what you've done with the project, it is by far the most usable and extendable react-based terminal. I noticed while using react-console-emulator, that the terminal can get very laggy when many high-speed terminal.pushToStdout() occur, and it gets much worse when the terminal output begins to be the length of millions. Implementing a solution using refs would be painful, and I think it would be much more reasonable to add the option for other people to use. I published a fork that implements the max output prop and submitted a pull request #1015.

Would this be something you are willing to implement?

@BjornTheProgrammer
Copy link
Author

Is there any plan to ever implement this? The pull request only has a single additional line of code, so it isn't much to review if you are worried about reviewing it. I also tested it utilizing the examples which are in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant