Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small typo in errorcodes.txt #73

Open
tasosval opened this issue Aug 23, 2019 · 3 comments
Open

Small typo in errorcodes.txt #73

tasosval opened this issue Aug 23, 2019 · 3 comments

Comments

@tasosval
Copy link
Contributor

Hello,

we came up to an unexpected error while testing inserting duplicate rows in a db table with UNIQUE KEY constraint

The problem was traced to the errorcodes.txt and specifically the first line which is currently:
unique,2627,Violation of UNIQUE KEY constraint '%.ls'..

While it should be
unique,2627,Violation of UNIQUE KEY constraint '(\S+?)'..*

as all the other lines are. This should be some sort typo, which I have seen has also been transferred to the TDS project.

@mjaric
Copy link
Collaborator

mjaric commented Aug 23, 2019

Hi @tasosval

Good finding, thanks! I missed to replace that somehow.

For now it should be in both repos. First I added it to tds_ecto and later introduced same thing in tds so I can migrate it there at some major version release. And hopefully make tds error labels similar to one that are in postgrex for some other ecto integration reasons.

Would you create PR for this repo?

Thank you

@tasosval
Copy link
Contributor Author

Sure thing. I will cook something up in the next couple of days. Thx for the immediate response

@tasosval
Copy link
Contributor Author

I have created a PR for this. Is there anything else I can do to help you resolve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants