Potential Misassignment of Variables in evaluate_frac Function

[Brycealong]

Hello Dr. Li,

First off, thank you for providing this amazing tool. As I go through the python files in the linux version, I find there might be some misassignment at the auto calculate window fraction section mentioned below. If you can quickly check the function again and let me know if there's indeed an issue, that will be great.

Issue:
There appears to be a potential issue with the assignment of the independent (x) and dependent (y) variables in the evaluate_frac function in the python file Statistic_Methods.py. Currently, the function treats data as the independent variable and position as the dependent variable. However, based on my understanding of this model, it might be more reasonable to treat data as the dependent variable (y) and position as the independent variable (x).

Current Implementation:

best_fraction = list(R.r['loess_as'](R.FloatVector(data), R.FloatVector(position)))[0]

Proposed Revision:

best_fraction = list(R.r['loess_as'](R.FloatVector(position), R.FloatVector(data)))[0]

Looking forward to your prompt attention to this matter.

Best regards,
Bryce

[lizhao007]

Hi Bryce,

I’m very sorry for seeing your message and responding so late. First, thank you for pointing out this issue—it does exist in the Linux version (although it has minimal impact on the results). We addressed this issue in Windows v1.5 and later, but the Linux version has not been updated beyond v1.4.

You can switch to the Windows version for future analyses. We apologize for any inconvenience this may have caused and thank you for your understanding!

Best regards,
Li, Zhao