Merge PR drone#9: Case insensitive match

Author: lkubb

plugin/match.go

@@ -23,3 +23,12 @@ func match(name string, patterns []string) bool {
 	}
 	return false
 }
+
+func matchCaseInsensitive(name string, params map[string]string) (string, bool) {
+	for key, value := range params {
+		if strings.ToLower(key) == strings.ToLower(name) {
+			return value, true
+		}
+	}
+	return "", false
+}

plugin/plugin.go

@@ -46,7 +46,7 @@ func (p *plugin) Find(ctx context.Context, req *secret.Request) (*drone.Secret,
 	if err != nil {
 		return nil, errors.New("secret not found")
 	}
-	value, ok := params[name]
+	value, ok := matchCaseInsensitive(name, params)
 	if !ok {
 		return nil, errors.New("secret key not found")
 	}

plugin/plugin_test.go

@@ -308,3 +308,45 @@ func Test_rewritePath(t *testing.T) {
 		})
 	}
 }
+
+func TestPlugin_FindMismatchCase(t *testing.T) {
+	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		out, _ := ioutil.ReadFile("testdata/uppercase_secret.json")
+		w.Write(out)
+	}))
+	defer ts.Close()
+
+	client, _ := api.NewClient(&api.Config{
+		Address:    ts.URL,
+		MaxRetries: 1,
+	})
+
+	req := &secret.Request{
+		Path: "secret/docker",
+		Name: "USERNAME",
+		Build: drone.Build{
+			Event:  "push",
+			Target: "master",
+		},
+		Repo: drone.Repo{
+			Slug: "octocat/hello-world",
+		},
+	}
+	plugin := New(client)
+	got, err := plugin.Find(noContext, req)
+	if err != nil {
+		t.Error(err)
+		return
+	}
+
+	want := &drone.Secret{
+		Name: "USERNAME",
+		Data: "david",
+		Pull: true,
+		Fork: true,
+	}
+	if diff := cmp.Diff(got, want); diff != "" {
+		t.Errorf(diff)
+		return
+	}
+}

plugin/testdata/uppercase_secret.json

@@ -0,0 +1,13 @@
+{
+  "data": {
+    "Username": "david",
+    "password": "BnQw&XDWgaEeT9XGTT29",
+    "X-Drone-Repos":"octocat/*",
+    "X-Drone-Events":"tag,push",
+    "X-Drone-Branches":"master",
+    "timestmap": 2764800
+  },
+  "lease_duration": 2764800,
+  "renewable": false,
+  "request_id": "5e246671-ec05-6fc8-9f93-4fe4512f34ab"
+}